Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container.provider): added container instances enforcement allowlist #5197

Merged
merged 27 commits into from
Apr 4, 2024

Conversation

sfiorani
Copy link
Contributor

@sfiorani sfiorani commented Apr 2, 2024

This PR adds an option to the Container Instances to be compliant with the Enforcement feature added to the Container Orchestration Service in #5162 and it's the second step of building the Container Authenticity feature.

This option allows the user to provide an Enforcement Digest for a specific Container Instance: when a container is enabled with the given option filled, the provided digest is added to the Container Orchestration Service enforcement allowlist. In this way the Container Instance is allowed to run even if in the Orchestration Service allowlist the digest is not included, because is the container instance to provide it.

Related docs is present in #5184 .

Related Issue:

Description of the solution adopted:

Screenshots:

Manual Tests:

Any side note on the changes made:

sfiorani and others added 22 commits March 1, 2024 15:27
…lidation of already running containers

Signed-off-by: SimoneFiorani <[email protected]>
@mattdibi mattdibi self-requested a review April 2, 2024 10:34
@sfiorani sfiorani marked this pull request as ready for review April 3, 2024 13:18
@sfiorani sfiorani marked this pull request as draft April 3, 2024 13:19
@sfiorani sfiorani marked this pull request as ready for review April 4, 2024 09:21
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reeeeeaaaaaaally small thing. Let me know what you think...

….eclipse.kura.container.provider.ContainerInstance.xml

Co-authored-by: Mattia Dal Ben <[email protected]>
@sfiorani sfiorani requested a review from mattdibi April 4, 2024 09:55
@mattdibi
Copy link
Contributor

mattdibi commented Apr 4, 2024

As per our offline discussion, among other smaller things, we decided to move the ContainerInstance digest allowlist from the Container Orchestrator to the Allowlist Enforcement Monitor for a better logic separation of the concerns.

…n/java/org/eclipse/kura/container/orchestration/provider/impl/enforcement/AllowlistEnforcementMonitor.java

Co-authored-by: Mattia Dal Ben <[email protected]>
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdibi
Copy link
Contributor

mattdibi commented Apr 4, 2024

As per our offline discussion, among other smaller things, we decided to move the ContainerInstance digest allowlist from the Container Orchestrator to the Allowlist Enforcement Monitor for a better logic separation of the concerns.

We discarded this since the only object that knows the digest associated with the Container Instances is the Container Orchestrator... it is natural to have it have the list of the digests.

@mattdibi
Copy link
Contributor

mattdibi commented Apr 4, 2024

The build succeeds locally but we are facing an issue in the CI connection to Sonar. An issue has been raised few weeks ago to the Eclipse Team: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4422

Merging as-is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants