fix(container.instance): refactored code to remove unreachable code #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdibi
reviewed
Apr 10, 2024
...r.provider.test/src/test/java/org/eclipse/kura/container/provider/ContainerInstanceTest.java
Outdated
Show resolved
Hide resolved
...r.provider.test/src/test/java/org/eclipse/kura/container/provider/ContainerInstanceTest.java
Show resolved
Hide resolved
mattdibi
approved these changes
Apr 10, 2024
|
The build succeeds locally but we are facing an issue in the CI connection to Sonar. An issue has been raised few weeks ago to the Eclipse Team: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4422 Merging as-is for now. |
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem in the Container Instance code that led to an unreachable code branch.
When a Container Instance in
Disabledstate started (startup of Kura or Instance creation) while an other container with same name was already running on the system, the latter was not stopped and deleted: this happened due to an incorrect exit condition of the update method that prevent the correct actions.Related Issue:
Description of the solution adopted:
Screenshots:
Manual Tests:
Any side note on the changes made: