Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nm): Modem APN as an optional parameter [backport release-5.6.0] #5353

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport 402e5e6 from #5350.

* Made apn an optional parameter

Signed-off-by: pierantoniomerlino <[email protected]>

* Fixed nm apn test

Signed-off-by: pierantoniomerlino <[email protected]>

---------

Signed-off-by: pierantoniomerlino <[email protected]>
(cherry picked from commit 402e5e6)
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdibi mattdibi merged commit 766a332 into release-5.6.0 Sep 13, 2024
3 checks passed
@mattdibi mattdibi deleted the backport-5350-to-release-5.6.0 branch September 13, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants