feat(api): added gnss type data to PositionService #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
mattdibi
reviewed
Oct 2, 2024
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/position/GNSSType.java
Outdated
Show resolved
Hide resolved
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/position/PositionService.java
Outdated
Show resolved
Hide resolved
...rg.eclipse.kura.linux.position/src/main/java/org/eclipse/kura/linux/position/NMEAParser.java
Show resolved
Hide resolved
...rg.eclipse.kura.linux.position/src/main/java/org/eclipse/kura/linux/position/NMEAParser.java
Show resolved
Hide resolved
mattdibi
reviewed
Oct 2, 2024
....kura.linux.position/src/main/java/org/eclipse/kura/linux/position/GpsdPositionProvider.java
Show resolved
Hide resolved
mattdibi
reviewed
Oct 2, 2024
...rg.eclipse.kura.linux.position/src/main/java/org/eclipse/kura/linux/position/NMEAParser.java
Show resolved
Hide resolved
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
mattdibi
reviewed
Oct 2, 2024
kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/position/PositionService.java
Outdated
Show resolved
Hide resolved
…ion/PositionService.java Co-authored-by: Mattia Dal Ben <[email protected]>
mattdibi
approved these changes
Oct 2, 2024
|
@sfiorani remember to open the issue for the known issue about the GNSSType reliability for GPSD Position Provider. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-5.6.0 release-5.6.0
# Navigate to the new working tree
cd .worktrees/backport-release-5.6.0
# Create a new branch
git switch --create backport-5381-to-release-5.6.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51fcd57437af67f22809b24ccc116b52c347c336
# Push it to GitHub
git push --set-upstream origin backport-5381-to-release-5.6.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-5.6.0Then, create a pull request where the |
sfiorani
added a commit
to sfiorani/kura
that referenced
this pull request
Oct 3, 2024
* feat(api): added gnss type data to PositionService Signed-off-by: SimoneFiorani <[email protected]> * test: added tests Signed-off-by: SimoneFiorani <[email protected]> * refactor: moved GNSSType enum to api bundle Signed-off-by: SimoneFiorani <[email protected]> * refactor: removed testing logger Signed-off-by: SimoneFiorani <[email protected]> * refactor: refactored gnsstype Signed-off-by: SimoneFiorani <[email protected]> * refactor: updated with suggestions Signed-off-by: SimoneFiorani <[email protected]> * fix: fixed line length Signed-off-by: SimoneFiorani <[email protected]> * Update kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/position/PositionService.java Co-authored-by: Mattia Dal Ben <[email protected]> * Update GNSSType.java --------- Signed-off-by: SimoneFiorani <[email protected]> Co-authored-by: Mattia Dal Ben <[email protected]> (cherry picked from commit 51fcd57)
This was referenced Oct 3, 2024
mattdibi
pushed a commit
that referenced
this pull request
Oct 4, 2024
…release-5.6.0] (#5407) feat(api): added gnss type data to PositionService (#5381) * feat(api): added gnss type data to PositionService Signed-off-by: SimoneFiorani <[email protected]> * test: added tests Signed-off-by: SimoneFiorani <[email protected]> * refactor: moved GNSSType enum to api bundle Signed-off-by: SimoneFiorani <[email protected]> * refactor: removed testing logger Signed-off-by: SimoneFiorani <[email protected]> * refactor: refactored gnsstype Signed-off-by: SimoneFiorani <[email protected]> * refactor: updated with suggestions Signed-off-by: SimoneFiorani <[email protected]> * fix: fixed line length Signed-off-by: SimoneFiorani <[email protected]> * Update kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/position/PositionService.java Co-authored-by: Mattia Dal Ben <[email protected]> * Update GNSSType.java --------- Signed-off-by: SimoneFiorani <[email protected]> Co-authored-by: Mattia Dal Ben <[email protected]> (cherry picked from commit 51fcd57)
salvatore-coppola
pushed a commit
that referenced
this pull request
Oct 4, 2024
* feat(api): added gnss type data to PositionService Signed-off-by: SimoneFiorani <[email protected]> * test: added tests Signed-off-by: SimoneFiorani <[email protected]> * refactor: moved GNSSType enum to api bundle Signed-off-by: SimoneFiorani <[email protected]> * refactor: removed testing logger Signed-off-by: SimoneFiorani <[email protected]> * refactor: refactored gnsstype Signed-off-by: SimoneFiorani <[email protected]> * refactor: updated with suggestions Signed-off-by: SimoneFiorani <[email protected]> * fix: fixed line length Signed-off-by: SimoneFiorani <[email protected]> * Update kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/position/PositionService.java Co-authored-by: Mattia Dal Ben <[email protected]> * Update GNSSType.java --------- Signed-off-by: SimoneFiorani <[email protected]> Co-authored-by: Mattia Dal Ben <[email protected]>
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
* feat(api): added gnss type data to PositionService Signed-off-by: SimoneFiorani <[email protected]> * test: added tests Signed-off-by: SimoneFiorani <[email protected]> * refactor: moved GNSSType enum to api bundle Signed-off-by: SimoneFiorani <[email protected]> * refactor: removed testing logger Signed-off-by: SimoneFiorani <[email protected]> * refactor: refactored gnsstype Signed-off-by: SimoneFiorani <[email protected]> * refactor: updated with suggestions Signed-off-by: SimoneFiorani <[email protected]> * fix: fixed line length Signed-off-by: SimoneFiorani <[email protected]> * Update kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/position/PositionService.java Co-authored-by: Mattia Dal Ben <[email protected]> * Update GNSSType.java --------- Signed-off-by: SimoneFiorani <[email protected]> Co-authored-by: Mattia Dal Ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new API to the PositionService: its aim is to provide information about the GNSS Type used to retrieve the position data
Related Issue:
Description of the solution adopted:
Screenshots:
Manual Tests:
Any side note on the changes made: