chore(poms): uptick version of properties maven plugin #5463
Conversation
There was a problem hiding this comment.
Thanks for the contribution! Could you please also update the other references and do a rebase with develop?
Line 96 in b2035df
|
Ok, I missed those. |
That would be really nice! I think that way it will be more maintainable |
gnunzi
force-pushed
the
uptick_maven_props
branch
from
537b996 to
979f31a
Compare
kura/distrib/pom.xml
Outdated
| @@ -93,7 +95,7 @@ | |||
| <plugin> | |||
| <groupId>org.codehaus.mojo</groupId> | |||
| <artifactId>properties-maven-plugin</artifactId> | |||
| <version>1.0-alpha-1</version> | |||
| <version>${properties-maven-plugin.version}/version> | |||
There was a problem hiding this comment.
| <version>${properties-maven-plugin.version}/version> | |
| <version>${properties-maven-plugin.version}</version> |
|
@marcellorinaldo the |
yes, i don't think it is used anymore |
|
@gnunzi thanks for your contribution 🙏 |
* uptick properties maven plugin * uptick properties maven plugin to 1.2.1 * fix typo (cherry picked from commit cdea82a)
…ase-5.6.0] (#5486) chore(poms): uptick version of properties maven plugin (#5463) * uptick properties maven plugin * uptick properties maven plugin to 1.2.1 * fix typo (cherry picked from commit cdea82a) Co-authored-by: gnunzi <[email protected]>
* uptick properties maven plugin * uptick properties maven plugin to 1.2.1 * fix typo
I noticed we are using an old alpha version of this plugin, so this is an uptick.
The properties maven plugin is used to read the file from target-platform/config/kura.target-platform.build.properties. It should be harmless to uptick.
On the other side, it is wise to move away from the alpha version.
References:
https://mvnrepository.com/artifact/org.codehaus.mojo/properties-maven-plugin/1.2.1
https://www.mojohaus.org/properties-maven-plugin/ (see top right for the version)