Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion from xsd doesn't cope with existing closing bracket #117

Closed
fbricon opened this issue Sep 11, 2018 · 1 comment
Closed

Autocompletion from xsd doesn't cope with existing closing bracket #117

fbricon opened this issue Sep 11, 2018 · 1 comment
Assignees
@angelozerr
Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Milestone
v0.0.1

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 11, 2018 •
edited
Loading

In a document with xsd, with an editor having autoclosing brackets enabled, typing "<" automatically inserts "<>". In that case, closing a tag works properly (inserts only /lastTag between the brackets, but node completion from the xsd ignores the closing tag (i.e. inserts othertag></othertag>, which means we end up with an extra >. Eg, a pom.xml in vscode with "editor.autoClosingBrackets": "always":

autocomplete-bracket-bug
@fbricon fbricon added bug Something isn't working completion This issue or enhancement is related to completion support labels Sep 11, 2018
@felixfbecker felixfbecker mentioned this issue Sep 14, 2018
Closed
@angelozerr angelozerr mentioned this issue Sep 14, 2018
Closed
angelozerr added a commit that referenced this issue Sep 14, 2018
@angelozerr
Remove '>' character when completion element is applied (see #117)
a4fc216
angelozerr added a commit that referenced this issue Sep 15, 2018
@angelozerr
Write test for #117
b23e994
@angelozerr
Copy link
Contributor

Should be fixed now:

closebracketandcope

@fbricon fbricon added this to the v0.0.1 milestone Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working completion This issue or enhancement is related to completion support
Projects
None yet
Milestone
v0.0.1
Development

No branches or pull requests
2 participants
@fbricon @angelozerr