-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Java 11 #1721
Update to Java 11 #1721
Conversation
Nice. And this will set us up to finally address #1291 (Fred has a draft PR for it) . |
I added the necessary reflection config to ensure the server launches. I poked around a bit with a few features and it seems to be working, with no exceptions in the logs. |
LGTM. I suggest that we merge the PR ASAP in order to see some potential problem when we will develop xml features. |
Hold on. I see lemminx/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/ToStringBuilder.java Lines 29 to 30 in e507183
|
@rgrunber I deleted that file and used the one from lsp4j; I'll double check the binary still works first though update yep it still works |
Another line about 1.8: I'll update jetty as well I guess update: I've updated jetty to the newest version that supports Java 11. Jetty is used in the test suite. |
- Bump to 0.30.0-SNPASHOT, since updating to Java 11 breaks API - Use `--release 11` in maven compiler plugin - Use Java 11 in the Jenkinsfiles - Use Java 11 in the GitHub Actions - Update tycho to 2.7.5 (the newest version that supports Java 11) - Update to the latest lsp4j, adapt to the API changes, and remove the guava exclusion (lsp4j no longer ships with guava, so we don't need to exclude it) Signed-off-by: David Thompson <[email protected]>
--release 11
in maven compiler pluginToStringBuilder
and use the one from lsp4j