Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Java 11 #1721

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Update to Java 11 #1721

merged 1 commit into from
Jan 9, 2025

Conversation

datho7561
Copy link
Contributor

@datho7561 datho7561 commented Jan 8, 2025

  • Bump to 0.30.0-SNPASHOT, since updating to Java 11 breaks API
  • Use --release 11 in maven compiler plugin
  • Use Java 11 in the Jenkinsfiles
  • Update tycho to 2.7.5 (the newest version that supports Java 11)
  • Update to the latest lsp4j, adapt to the API changes, and remove the guava exclusion (lsp4j no longer ships with guava, so we don't need to exclude it)
  • Delete ToStringBuilder and use the one from lsp4j
  • Update to the newest jetty version that supports Java 11

@rgrunber
Copy link
Contributor

rgrunber commented Jan 8, 2025

Nice. And this will set us up to finally address #1291 (Fred has a draft PR for it) .

@datho7561 datho7561 marked this pull request as ready for review January 8, 2025 17:05
@datho7561
Copy link
Contributor Author

I added the necessary reflection config to ensure the server launches. I poked around a bit with a few features and it seems to be working, with no exceptions in the logs.

@datho7561 datho7561 requested a review from angelozerr January 8, 2025 17:06
@angelozerr
Copy link
Contributor

LGTM.

I suggest that we merge the PR ASAP in order to see some potential problem when we will develop xml features.

@rgrunber
Copy link
Contributor

rgrunber commented Jan 8, 2025

Hold on. I see a few one reference to 1.8 related stuff. Would be good to verify whether this should remain or change :

* @implNote This class originally came from xbase.lib and has been extended for LSP4J purposes with some additional functionality.
* It then was copied due to java 1.8 compatibility requirements into lemminx.

@datho7561
Copy link
Contributor Author

datho7561 commented Jan 8, 2025

@rgrunber I deleted that file and used the one from lsp4j; I'll double check the binary still works first though

update yep it still works

@datho7561
Copy link
Contributor Author

datho7561 commented Jan 8, 2025

Another line about 1.8:
https://github.com/eclipse-lemminx/lemminx/blob/main/org.eclipse.lemminx/pom.xml#L294

I'll update jetty as well I guess

update: I've updated jetty to the newest version that supports Java 11. Jetty is used in the test suite.

- Bump to 0.30.0-SNPASHOT, since updating to Java 11 breaks API
- Use `--release 11` in maven compiler plugin
- Use Java 11 in the Jenkinsfiles
- Use Java 11 in the GitHub Actions
- Update tycho to 2.7.5 (the newest version that supports Java 11)
- Update to the latest lsp4j, adapt to the API changes, and remove the
  guava exclusion (lsp4j no longer ships with guava, so we don't need to
  exclude it)

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 requested a review from angelozerr January 8, 2025 22:23
@datho7561 datho7561 merged commit 89fa2bb into eclipse-lemminx:main Jan 9, 2025
5 of 6 checks passed
@datho7561 datho7561 deleted the java11 branch January 9, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants