Fix error range for EntityNotDeclared #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we underline both the starting |
|
That's how eclipse does it:
|
fbricon
reviewed
Jul 22, 2019
...xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/participants/DTDErrorCode.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jul 22, 2019
| int end = start + name.length(); | ||
| Position startPosition = new Position(line, start); | ||
| Position endPosition = new Position(line, end); | ||
| return new Range(startPosition, endPosition); |
There was a problem hiding this comment.
note for later: we should have a public static Range newRange(line, start, end) utility method somewhere
There was a problem hiding this comment.
should this change take place in a different PR?
There was a problem hiding this comment.
XMLPositionUtility is the best place to add this method
Signed-off-by: David Kwon <[email protected]>
XMLPositionUtility is the best place to add this method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error range mentioned in #518
I am using the name of the undeclared entity, (in this case, "nbsp"), looking for the substring " " in the line provided by xerces to determine the error range.
Signed-off-by: David Kwon [email protected]