Extension completion should use node text range #837
Conversation
|
This probably needs a test. I can confirm however that it fixes the issue related to eclipse-lemminx/lemminx-maven#127 (I removed the workaround but kept the test from that PR) |
Yes please. |
|
@angelozerr should the test just extend |
Fix eclipse-lemminx#723 Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow
force-pushed
the
completionRequest_slash_bug
branch
from
763ed34 to
f74c30e
Compare
| @@ -753,6 +754,18 @@ private void collectInsideContent(CompletionRequest request, CompletionResponse | |||
| collectCloseTagSuggestions(tagNameRange, true, true, false, request, response); | |||
| } | |||
| // Participant completion on XML content | |||
| if (request.getNode() instanceof DOMElement) { | |||
There was a problem hiding this comment.
I think this section about DOMElement probably should be removed, I don't think it actually addresses the issue that was reported (even though it made downstream lemminx-maven workaround tests pass..).
The original bug was about triggering a completion on text, not on a node?
|
|
||
| @Test | ||
| private void testHTMLOnXMLContentCompletion() throws BadLocationException { | ||
| // TODO: This isin't getting called by Junit |
There was a problem hiding this comment.
I don't know why I couldn't get my test to be called :P Is there anything I'm missing to get it called? For now I put the test code in testHTMLAttributeValueCompletion so that it'd be called on CI
|
This PR is replaced with #866 |
Fix #723
Signed-off-by: Andrew Obuchowicz [email protected]