Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support super- and subtype hierarchies #272

Closed
kittaakos opened this issue Oct 9, 2018 · 5 comments · Fixed by #273
Closed

Support super- and subtype hierarchies #272

kittaakos opened this issue Oct 9, 2018 · 5 comments · Fixed by #273
Assignees
Milestone

Comments

@kittaakos
Copy link
Contributor

To support the super- and subtype hierarchies via the LSP, we need to:

@kittaakos kittaakos self-assigned this Oct 9, 2018
kittaakos pushed a commit to kittaakos/lsp4j that referenced this issue Oct 9, 2018
 - Added optional `uri` property to the `DocumentSymbol`.
 - Added methods for super- and subtype hierarchies.

Closes: eclipse-lsp4j#272

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit to kittaakos/lsp4j that referenced this issue Oct 10, 2018
 - Added optional `uri` property to the `DocumentSymbol`.
 - Added methods for super- and subtype hierarchies.

Closes: eclipse-lsp4j#272

Signed-off-by: Akos Kitta <[email protected]>
@tsmaeder
Copy link

I am strictly opposed to introducing things in lsp4j that are not officially supported in LSP. It is quite easy to extend LSP with custom messages and that should be the way to go if we are not happy with the standard. LSP4J should be an implementation of LSP, nothing more, nothing less.

@KamasamaK
Copy link
Contributor

@tsmaeder That is probably the reason for creating PRs for both proposals on Microsoft/vscode-languageserver-node, which is the de facto reference implementation and is in accordance with their contributing guidelines.

The maintainer did not seem opposed to the concept of the proposal in the previous PR, but just had some criticisms, so we'll just have to see what feedback there is.

@spoenemann
Copy link
Contributor

I am strictly opposed to introducing things in lsp4j that are not officially supported in LSP.

LSP is evolving very quickly and so is its support in the languages and clients. We have seen quite a lot of requests from various sides for implementing proposed, but not yet officially approved extensions of the protocol in LSP4J. I think it's fine to add them to the Java API as long as we mark them with @Beta and add a note to their Javadoc.

@spoenemann spoenemann added this to the v0.6.0 milestone Oct 29, 2018
@olafurpg
Copy link

Can non-LSP approved features maybe be published as a separate module lsp4j-beta?

@spoenemann
Copy link
Contributor

Can non-LSP approved features maybe be published as a separate module lsp4j-beta?

That's not always possible since such features might be additional fields of a non-beta class, so we'd have a dependency from the main module to the beta module.

@spoenemann spoenemann modified the milestones: v0.6.0, v0.7.0 Dec 5, 2018
kittaakos pushed a commit to kittaakos/lsp4j that referenced this issue Jan 22, 2019
kittaakos pushed a commit to kittaakos/lsp4j that referenced this issue Jan 23, 2019
kittaakos pushed a commit to kittaakos/lsp4j that referenced this issue Jan 23, 2019
kittaakos pushed a commit to kittaakos/lsp4j that referenced this issue Jan 24, 2019
kittaakos added a commit that referenced this issue Jan 24, 2019
GH-272: Updated the API to support type hierarchies.
vladdu pushed a commit to vladdu/lsp4j that referenced this issue Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants