-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support super- and subtype hierarchies #272
Comments
- Added optional `uri` property to the `DocumentSymbol`. - Added methods for super- and subtype hierarchies. Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <[email protected]>
- Added optional `uri` property to the `DocumentSymbol`. - Added methods for super- and subtype hierarchies. Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <[email protected]>
I am strictly opposed to introducing things in lsp4j that are not officially supported in LSP. It is quite easy to extend LSP with custom messages and that should be the way to go if we are not happy with the standard. LSP4J should be an implementation of LSP, nothing more, nothing less. |
@tsmaeder That is probably the reason for creating PRs for both proposals on Microsoft/vscode-languageserver-node, which is the de facto reference implementation and is in accordance with their contributing guidelines. The maintainer did not seem opposed to the concept of the proposal in the previous PR, but just had some criticisms, so we'll just have to see what feedback there is. |
LSP is evolving very quickly and so is its support in the languages and clients. We have seen quite a lot of requests from various sides for implementing proposed, but not yet officially approved extensions of the protocol in LSP4J. I think it's fine to add them to the Java API as long as we mark them with |
Can non-LSP approved features maybe be published as a separate module |
That's not always possible since such features might be additional fields of a non-beta class, so we'd have a dependency from the main module to the beta module. |
Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <[email protected]>
Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <[email protected]>
Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <[email protected]>
Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <[email protected]>
GH-272: Updated the API to support type hierarchies.
Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <[email protected]>
To support the super- and subtype hierarchies via the LSP, we need to:
DocumentSymbol
API, add an optional URI property,DocumentSymbol
for the hierarchical nodes.The text was updated successfully, but these errors were encountered: