Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gson to accept wider version #836

Closed
jonahgraham opened this issue May 21, 2024 · 1 comment · Fixed by #837
Closed

Update Gson to accept wider version #836

jonahgraham opened this issue May 21, 2024 · 1 comment · Fixed by #837
Milestone

Comments

@jonahgraham
Copy link
Contributor

Yesterday a new version of gson was released. If possible we should widen our version range to accept this new version. Need to run japicmp to make sure that there are no API changes that affect us.

If it is just a version change we'll release a 0.23.1 version of LSP4J so consumers don't need to take any additional action/rebuild and SimRel will end up with the right value.

@jonahgraham
Copy link
Contributor Author

There aren't any API breaking changes according to japicmp tool:

$ java -jar japicmp.jar --html-file japicmp-report/gson-2.11.0.html  --only-modified --ignore-missing-classes -n gson-2.11.0.jar -o  gson-2.10.1.jar -e com.google.gson.internal.*
Comparing source compatibility of /tmp/tmp.cHkSYQlLyS/gson-2.11.0.jar against /tmp/tmp.cHkSYQlLyS/gson-2.10.1.jar
WARNING: You are using the option '--ignore-missing-classes', i.e. superclasses and interfaces that could not be found on the classpath are ignored. Hence changes caused by these superclasses and interfaces are not reflected in the output.
+++  NEW CLASS: PUBLIC(+) com.google.gson.FormattingStyle  (not serializable)
        +++  CLASS FILE FORMAT VERSION: 51.0 <- n.a.
        +++  NEW SUPERCLASS: java.lang.Object
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) com.google.gson.FormattingStyle COMPACT
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) com.google.gson.FormattingStyle PRETTY
        +++  NEW METHOD: PUBLIC(+) java.lang.String getIndent()
        +++  NEW METHOD: PUBLIC(+) java.lang.String getNewline()
        +++  NEW METHOD: PUBLIC(+) boolean usesSpaceAfterSeparators()
        +++  NEW METHOD: PUBLIC(+) com.google.gson.FormattingStyle withIndent(java.lang.String)
        +++  NEW METHOD: PUBLIC(+) com.google.gson.FormattingStyle withNewline(java.lang.String)
        +++  NEW METHOD: PUBLIC(+) com.google.gson.FormattingStyle withSpaceAfterSeparators(boolean)
***  MODIFIED CLASS: PUBLIC FINAL com.google.gson.GsonBuilder  (not serializable)
        ===  CLASS FILE FORMAT VERSION: 51.0 <- 51.0
        ===  UNCHANGED METHOD: PUBLIC com.google.gson.GsonBuilder setDateFormat(int)
                +++  NEW ANNOTATION: java.lang.Deprecated
        +++  NEW METHOD: PUBLIC(+) com.google.gson.GsonBuilder setFormattingStyle(com.google.gson.FormattingStyle)
        ===  UNCHANGED METHOD: PUBLIC com.google.gson.GsonBuilder setLenient()
                +++  NEW ANNOTATION: java.lang.Deprecated
        +++  NEW METHOD: PUBLIC(+) com.google.gson.GsonBuilder setStrictness(com.google.gson.Strictness)
***  MODIFIED CLASS: PUBLIC com.google.gson.stream.JsonReader  (not serializable)
        ===  CLASS FILE FORMAT VERSION: 51.0 <- 51.0
        +++  NEW METHOD: PUBLIC(+) FINAL(+) com.google.gson.Strictness getStrictness()
        ===  UNCHANGED METHOD: PUBLIC FINAL void setLenient(boolean)
                +++  NEW ANNOTATION: java.lang.Deprecated
        +++  NEW METHOD: PUBLIC(+) FINAL(+) void setStrictness(com.google.gson.Strictness)
***  MODIFIED CLASS: PUBLIC com.google.gson.stream.JsonWriter  (not serializable)
        ===  CLASS FILE FORMAT VERSION: 51.0 <- 51.0
        +++  NEW METHOD: PUBLIC(+) FINAL(+) com.google.gson.FormattingStyle getFormattingStyle()
        +++  NEW METHOD: PUBLIC(+) FINAL(+) com.google.gson.Strictness getStrictness()
        +++  NEW METHOD: PUBLIC(+) FINAL(+) void setFormattingStyle(com.google.gson.FormattingStyle)
        ===  UNCHANGED METHOD: PUBLIC FINAL void setLenient(boolean)
                +++  NEW ANNOTATION: java.lang.Deprecated
        +++  NEW METHOD: PUBLIC(+) FINAL(+) void setStrictness(com.google.gson.Strictness)
+++  NEW ENUM: PUBLIC(+) FINAL(+) com.google.gson.Strictness  (compatible)
        +++  CLASS FILE FORMAT VERSION: 51.0 <- n.a.
        +++  NEW INTERFACE: java.lang.constant.Constable
        +++  NEW INTERFACE: java.lang.Comparable
        +++  NEW INTERFACE: java.io.Serializable
        +++  NEW SUPERCLASS: java.lang.Enum
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) com.google.gson.Strictness STRICT
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) com.google.gson.Strictness LENIENT
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) com.google.gson.Strictness LEGACY_STRICT
        +++  NEW METHOD: PUBLIC(+) STATIC(+) com.google.gson.Strictness valueOf(java.lang.String)
        +++  NEW METHOD: PUBLIC(+) STATIC(+) com.google.gson.Strictness[] values()

jonahgraham added a commit that referenced this issue May 21, 2024
Fixes #836

Signed-off-by: Christian Dietrich <[email protected]>
Co-authored-by: Jonah Graham <[email protected]>
@jonahgraham jonahgraham added this to the 0.23.1 milestone May 21, 2024
jonahgraham added a commit to jonahgraham/lsp4j that referenced this issue May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant