Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated significant portion for LSP 3.15 #397

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

KamasamaK
Copy link
Contributor

@KamasamaK KamasamaK commented Jan 20, 2020

I went through most of the LSP 3.15 changes and below is the summary of my changes:

  • Removed @Betafrom textDocument/selectionRange items
  • Add support for server and client information.
  • Add signature help context.
  • Fixed version on PublishDiagnosticsParams (see below) and added missing client capability.
  • Add CodeAction#isPreferred support.
  • Add CompletionItem#tag support.
  • Add DocumentLink#tooltip support.
  • Add trimTrailingWhitespace, insertFinalNewline and trimFinalNewlines to FormattingOptions.
  • Clarified WorkspaceSymbolParams#query parameter.
  • Deprecated MarkedString
  • Deprecated rangeLength in TextDocumentContentChangeEvent
  • Misc. spelling/grammar fixes

Breaking API changes (stable):

  • valueSet of CodeActionKindCapabilities set to @NonNull
  • Signature of textDocument/signatureHelp changed from signatureHelp(TextDocumentPositionParams position) to signatureHelp(SignatureHelpParams params)

Breaking API changes (preview):

  • valueSet of DiagnosticTagSupport set to @NonNull
  • version of PublishDiagnosticsParams changed from int to Integer

Still missing for complete 3.15:

@eclipse-lsp4j-bot
Copy link

Can one of the admins verify this patch?

@jonahgraham
Copy link
Contributor

@KamasamaK I have added you to the whitelist so your PRs should build automatically in the future.

Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you!

@spoenemann spoenemann added this to the v0.9.0 milestone Jan 21, 2020
@spoenemann
Copy link
Contributor

@KamasamaK would you like to become a project committer?

See https://projects.eclipse.org/projects/technology.lsp4j/who

@jonahgraham jonahgraham self-requested a review January 27, 2020 18:29
Copy link
Contributor

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KamasamaK,

Thanks for the changes - please add the API changes to the Changelog.

Also, please ensure your Author/Signed-Off-By is your legal name rather than your GitHub username, (quote from https://www.eclipse.org/projects/handbook/#resources-commit):

The named used in the Author field (and, when required, in the Also-by and Signed-off-by fields) must be the legal name of the contributor; the email address must be valid and real.

@jonahgraham
Copy link
Contributor

I am not sure what, if anything, prevented @spoenemann from merging this after reviewing it successfully. But this gives us a chance to fix up some administrative stuff in the commits.

@KamasamaK KamasamaK force-pushed the lsp-3.15-incomplete branch from 13d485f to d8e3d1a Compare January 29, 2020 23:23
@KamasamaK
Copy link
Contributor Author

@spoenemann

@KamasamaK would you like to become a project committer?

Sure. What is the process for that?

@jonahgraham I think I addressed all the issues you mentioned.

@jonahgraham
Copy link
Contributor

Thanks @KamasamaK - I will merge this tomorrow and then apply the downstream changes to LSP4E I have lined up to fix the API changes.


I am very grateful for the thoroughness of your reviews and think you would be a good addition to the LSP4J project. As for process @spoenemann will create a new committer vote with the justifaction/contributions you have done and the existing committers and project management committee (PMC) will vote. You can read the full process here https://www.eclipse.org/projects/handbook/#elections-committer - although it may be best to continue this conversation on the lsp4j-dev mailing list rather than hiding it within this PR :-)

@spoenemann
Copy link
Contributor

As for process @spoenemann will create a new committer vote with the justifaction/contributions you have done and the existing committers and project management committee (PMC) will vote.

The process has started. @KamasamaK would you mind changing your Eclipse profile so it includes your real name? This is important for transparency of the project, see https://projects.eclipse.org/projects/technology.lsp4j/who

@jonahgraham
Copy link
Contributor

#369 (comment)

@KamasamaK please see above q from
@cdietrich

@jonahgraham
Copy link
Contributor

As for process @spoenemann will create a new committer vote with the justifaction/contributions you have done and the existing committers and project management committee (PMC) will vote.

The process has started. @KamasamaK would you mind changing your Eclipse profile so it includes your real name? This is important for transparency of the project, see https://projects.eclipse.org/projects/technology.lsp4j/who

@spoenemann should the election be restarted after the name has been updated otherwise the election will have the pseudonym in the URL: https://projects.eclipse.org/projects/technology.lsp4j/elections/election-kama-sama-committer-eclipse-lsp4j - I am +1 aside from this

@KamasamaK
Copy link
Contributor Author

@spoenemann @jonahgraham I tried to change that profile a few days ago and again just now, but it's been unsuccessful. When saving the changes, I get logged out and shown a message that says "A password request change has been submitted for your Eclipse account. Please try to login with your new password." and when logging back in (with the same password) nothing changed.

I agree with @jonahgraham that this should probably not be in the PR but this tech support issue doesn't exactly seem appropriate for the lsp4j-dev mailing list either.

@jonahgraham
Copy link
Contributor

OK - well lets continue here for now :-) Can you email [email protected] and request your account name be fixed please?

@jonahgraham jonahgraham merged commit 21c94d0 into eclipse-lsp4j:master Jan 30, 2020
@KamasamaK
Copy link
Contributor Author

The name on my account has been updated.

@KamasamaK KamasamaK deleted the lsp-3.15-incomplete branch January 31, 2020 02:20
@spoenemann
Copy link
Contributor

This election failed to receive the required number of votes in the alotted time.

I'm starting a new one.

vladdu pushed a commit to vladdu/lsp4j that referenced this pull request Jan 26, 2021
adietish pushed a commit to adietish/lsp4j that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants