-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated significant portion for LSP 3.15 #397
Updated significant portion for LSP 3.15 #397
Conversation
Can one of the admins verify this patch? |
29e37b1
to
4ae84e8
Compare
@KamasamaK I have added you to the whitelist so your PRs should build automatically in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you!
@KamasamaK would you like to become a project committer? See https://projects.eclipse.org/projects/technology.lsp4j/who |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KamasamaK,
Thanks for the changes - please add the API changes to the Changelog.
Also, please ensure your Author/Signed-Off-By is your legal name rather than your GitHub username, (quote from https://www.eclipse.org/projects/handbook/#resources-commit):
The named used in the Author field (and, when required, in the Also-by and Signed-off-by fields) must be the legal name of the contributor; the email address must be valid and real.
I am not sure what, if anything, prevented @spoenemann from merging this after reviewing it successfully. But this gives us a chance to fix up some administrative stuff in the commits. |
Signed-off-by: Matthew Brown <[email protected]>
13d485f
to
d8e3d1a
Compare
Sure. What is the process for that? @jonahgraham I think I addressed all the issues you mentioned. |
Thanks @KamasamaK - I will merge this tomorrow and then apply the downstream changes to LSP4E I have lined up to fix the API changes. I am very grateful for the thoroughness of your reviews and think you would be a good addition to the LSP4J project. As for process @spoenemann will create a new committer vote with the justifaction/contributions you have done and the existing committers and project management committee (PMC) will vote. You can read the full process here https://www.eclipse.org/projects/handbook/#elections-committer - although it may be best to continue this conversation on the lsp4j-dev mailing list rather than hiding it within this PR :-) |
The process has started. @KamasamaK would you mind changing your Eclipse profile so it includes your real name? This is important for transparency of the project, see https://projects.eclipse.org/projects/technology.lsp4j/who |
@KamasamaK please see above q from |
@spoenemann should the election be restarted after the name has been updated otherwise the election will have the pseudonym in the URL: https://projects.eclipse.org/projects/technology.lsp4j/elections/election-kama-sama-committer-eclipse-lsp4j - I am +1 aside from this |
@spoenemann @jonahgraham I tried to change that profile a few days ago and again just now, but it's been unsuccessful. When saving the changes, I get logged out and shown a message that says "A password request change has been submitted for your Eclipse account. Please try to login with your new password." and when logging back in (with the same password) nothing changed. I agree with @jonahgraham that this should probably not be in the PR but this tech support issue doesn't exactly seem appropriate for the lsp4j-dev mailing list either. |
OK - well lets continue here for now :-) Can you email [email protected] and request your account name be fixed please? |
The name on my account has been updated. |
I'm starting a new one. |
Signed-off-by: Matthew Brown <[email protected]>
Fixes eclipse-lsp4j#397 Signed-off-by: azerr <[email protected]>
I went through most of the LSP 3.15 changes and below is the summary of my changes:
@Beta
fromtextDocument/selectionRange
itemsversion
onPublishDiagnosticsParams
(see below) and added missing client capability.MarkedString
rangeLength
inTextDocumentContentChangeEvent
Breaking API changes (stable):
valueSet
ofCodeActionKindCapabilities
set to@NonNull
textDocument/signatureHelp
changed fromsignatureHelp(TextDocumentPositionParams position)
tosignatureHelp(SignatureHelpParams params)
Breaking API changes (preview):
valueSet
ofDiagnosticTagSupport
set to@NonNull
version
ofPublishDiagnosticsParams
changed fromint
toInteger
Still missing for complete 3.15: