Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for jakarta namespace #229

Closed
yeekangc opened this issue Apr 7, 2022 · 4 comments · Fixed by #332
Closed

Add support for jakarta namespace #229

yeekangc opened this issue Apr 7, 2022 · 4 comments · Fixed by #332
Assignees
@datho7561

Comments

@yeekangc
Copy link

yeekangc commented Apr 7, 2022

MP 5 supports jakarta namespace aligning with Jakarta EE 9/9.1. The LS should support the use of packages with the jakarta namespace.

Cc @kathrynkodama
@angelozerr
Copy link
Contributor

Is it possible to explain more which support you wish to have with a sample please.

@kathrynkodama
Copy link
Contributor

For example, updating the snippets that use the old javax namespace to jakarta if Jakarta EE 9/9.1+ is in use.
https://github.com/eclipse/lsp4mp/blob/9789a1a996811fade43029605c014c7825e8f1da/microprofile.ls/org.eclipse.lsp4mp.ls/src/main/resources/org/eclipse/lsp4mp/snippets/mp-restclient.json#L9-L12
would become:

"import jakarta.enterprise.context.ApplicationScoped;",
"import jakarta.ws.rs.GET;",
"import jakarta.ws.rs.Path;",
"import jakarta.ws.rs.PathParam;",

@angelozerr
Copy link
Contributor

Ok I see, thanks @kathrynkodama for your feedback. Any contribution are welcome :)

@datho7561
Copy link
Contributor

datho7561 commented Nov 10, 2022 •
edited
Loading

Another part of this issue, which I've started to look at in #313, is making sure that the CodeLens for JAX-RS and RestClient appear in cases where Path and GET are imported using the jakarta namespace.

datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 7, 2022
@datho7561
Use jakarta imports in snippets when possible
0c5b5b3 
If the jakarta versions of the javax classes referenced in the current
snippets are on the classpath, hide the old snippet and display a new
snippet that imports the jakarta classes instead.

Closes eclipse-lsp4mp#229

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 mentioned this issue Dec 7, 2022
Closed
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 7, 2022
@datho7561
Use jakarta imports in snippets when possible
589a877 
If the jakarta versions of the javax classes referenced in the current
snippets are on the classpath, hide the old snippet and display a new
snippet that imports the jakarta classes instead.

Closes eclipse-lsp4mp#229, eclipse-lsp4mp#320

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 7, 2022
@datho7561
Use jakarta imports in snippets when possible
b02e11c 
If the jakarta versions of the javax classes referenced in the current
snippets are on the classpath, hide the old snippet and display a new
snippet that imports the jakarta classes instead.

Closes eclipse-lsp4mp#229, closes eclipse-lsp4mp#320

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 7, 2022
@datho7561
Use jakarta imports in snippets when possible
17b0c22 
If the jakarta versions of the javax classes referenced in the current
snippets are on the classpath, hide the old snippet and display a new
snippet that imports the jakarta classes instead.

Closes eclipse-lsp4mp#229, closes eclipse-lsp4mp#320

Signed-off-by: David Thompson <[email protected]>
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 9, 2022
@datho7561
Use template to determine jakarta namespace in snippets
0acc431 
- Use `${jakarta}` to point to either `javax` or `jakarta`, depending on
  which is available, and prefering `jakarta`
- Rename `jaxrc` to `rest_class` and `jaxrm` to `rest_get`

Closes eclipse-lsp4mp#320, closes eclipse-lsp4mp#229

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 mentioned this issue Dec 9, 2022
Merged
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 9, 2022
@datho7561
Use template to determine jakarta namespace in snippets
2d6ad46 
- Use `${jakarta}` to point to either `javax` or `jakarta`, depending on
  which is available, and prefering `jakarta`
- Rename `jaxrc` to `rest_class` and `jaxrm` to `rest_get`

Closes eclipse-lsp4mp#320, closes eclipse-lsp4mp#229

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 self-assigned this Dec 9, 2022
@rgrunber rgrunber moved this to 🏗 In progress in IDE Cloudaptors Dec 14, 2022
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 14, 2022
@datho7561
Use template to determine jakarta namespace in snippets
1f4ec24 
- Use `${jakarta}` to point to either `javax` or `jakarta`, depending on
  which is available, and prefering `jakarta`
- Rename `jaxrc` to `rest_class` and `jaxrm` to `rest_get`

Closes eclipse-lsp4mp#320, closes eclipse-lsp4mp#229

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors Dec 14, 2022
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Dec 15, 2022
@datho7561
Use template to determine jakarta namespace in snippets
b3993d8 
- Use `${jakarta}` to point to either `javax` or `jakarta`, depending on
  which is available, and prefering `jakarta`
- Rename `jaxrc` to `rest_class` and `jaxrm` to `rest_get`

Closes eclipse-lsp4mp#320, closes eclipse-lsp4mp#229

Signed-off-by: David Thompson <[email protected]>
angelozerr pushed a commit that referenced this issue Dec 16, 2022
@datho7561 @angelozerr
Use template to determine jakarta namespace in snippets
7591749 
- Use `${jakarta}` to point to either `javax` or `jakarta`, depending on
  which is available, and prefering `jakarta`
- Rename `jaxrc` to `rest_class` and `jaxrm` to `rest_get`

Closes #320, closes #229

Signed-off-by: David Thompson <[email protected]>
Repository owner moved this from 👀 In review to ✅ Done in IDE Cloudaptors Dec 16, 2022
@rgrunber rgrunber mentioned this issue Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@angelozerr @yeekangc @datho7561 @kathrynkodama