Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk24 OpenJDK java/foreign/critical/TestCritical expected [42] but found [0] #21018

Open
pshipton opened this issue Jan 25, 2025 · 3 comments
Open

Comments

@pshipton
Copy link
Member

https://openj9-jenkins.osuosl.org/job/Test_openjdk24_j9_sanity.openjdk_aarch64_mac_Nightly_testList_1/3
java/foreign/critical/TestCritical.java

20:46:23  NativeTestHelper::DEFAULT_RANDOM.seed = -934734214
20:46:23  Re-run with '-DNativeTestHelper.DEFAULT_RANDOM.seed=-934734214' to reproduce
20:46:23  test TestCritical.testAllowHeap(TestCritical$AllowHeapCase@c1a75416): failure
20:46:23  java.lang.AssertionError: expected [42] but found [0]
20:46:23  	at org.testng.Assert.fail(Assert.java:99)
20:46:23  	at org.testng.Assert.failNotEquals(Assert.java:1037)
20:46:23  	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
20:46:23  	at org.testng.Assert.assertEquals(Assert.java:122)
20:46:23  	at org.testng.Assert.assertEquals(Assert.java:907)
20:46:23  	at org.testng.Assert.assertEquals(Assert.java:917)
20:46:23  	at TestCritical.testAllowHeap(TestCritical.java:141)
@pshipton
Copy link
Member Author

Exclude it via adoptium/aqa-tests#5912

@babsingh
Copy link
Contributor

babsingh commented Feb 4, 2025

@theresa-m Can you please take a look at this issue?

There is a recent commit in the JDK24 extension repo where TestCritical testAllowHeap is modified: 8336768: Allow captureCallState and critical linker options to be combined. There might be API changes that we need to reflect in our implementation. To begin the investigation, we should run the test with RI's latest JDK24 early-access build to see if it passes the test.

@theresa-m
Copy link
Contributor

I confirmed that this is passing with an OpenJDK build. I will take a look at the recent extensions change to see if I can find anything that's missing from OpenJ9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants