Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set aladd/aiadd as internalPtr in calculateElementAddress #13294

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Set aladd/aiadd as internalPtr in calculateElementAddress #13294

merged 1 commit into from
Oct 18, 2021

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Aug 7, 2021

Set aladd/aiadd as internal pointer in calculateElementAddress

Signed-off-by: Annabelle Huo [email protected]

@a7ehuo a7ehuo requested review from 0xdaryl and hzongaro August 7, 2021 23:41
hzongaro
hzongaro approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Aug 12, 2021

@0xdaryl Ready for review. Thanks Daryl!

@0xdaryl
Copy link
Contributor

0xdaryl commented Aug 13, 2021

Jenkins test sanity all jdk11,jdk16

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Aug 18, 2021

Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal failed due to a crash in J9vmTest_5. There is another prior PR build test with similar crash in J9vmTest_0. It looks to be related to #9782 (comment).

+++ j9vm.test.arraycopy.MultiThreadedBackwardArrayCopyTest: +++
command: /Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/openjdkbinary/j2sdk-image/bin/java  -Xcompressedrefs -Xjit -Xgcpolicy:gencon  -Xdump -Xms64m -Xmx64m    -classpath /Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/../../jvmtest/functional/VM_Test/VM_Test.jar:/Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/../TKG/lib/asm-all.jar  j9vm.test.arraycopy.MultiThreadedBackwardArrayCopyTest 

EFlags 10602, EFlags & 0x400 = 400, DF flag is set
Unhandled exception
Type=Segmentation error vmState=0x00000000
J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000000
Handler1=000000000B437300 Handler2=000000000AA923C0
RDI=00000000FF8B7B98 RSI=00000000FF8B7B94 RAX=00000000FF8B7B48 RBX=00000000FF95CC38
RCX=000000000000000F RDX=0000000000000020 R8=0000000000000022 R9=0000000000000000
R10=000000000002D791 R11=000000000D8B2000 R12=00000000FF95CC38 R13=00000000FF8F5D10
R14=00000000FF8B7B48 R15=00000000FF972FC0
RIP=00000000229E6F2D GS=0000 FS=0000 RSP=000000000D8B13E0
RFlags=0000000000010602 CS=002B RBP=000000000D8B1600 ERR=0468700000000000
TRAPNO=000000000000000D CPU=7000000000000000 FAULTVADDR=0000000104687000
XMM0 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM1 000000000d8b1450 (f: 227218512.000000, d: 1.122609e-315)
XMM2 000e1781000e1781 (f: 923521.000000, d: 1.959708e-308)
XMM3 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM4 00000000ff972fc0 (f: 4288098304.000000, d: 2.118602e-314)
XMM5 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM6 3fdf884a36fe9ec2 (f: 922656448.000000, d: 4.926935e-01)
XMM7 402e7f9c1e980fa9 (f: 513281952.000000, d: 1.524924e+01)
XMM8 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM10 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM11 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM15 0000000000000000 (f: 0.000000, d: 0.000000e+00)

Compiled_method=j9vm/test/arraycopy/MultiThreadedBackwardArrayCopyTest.rotateSource()V
Target=2_90_20210813_127 (Mac OS X 10.11.6)
CPU=amd64 (4 logical CPUs) (0x200000000 RAM)
----------- Stack Backtrace -----------
---------------------------------------
JVMDUMP039I Processing dump event "gpf", detail "" at 2021/08/13 09:38:48 - please wait.
JVMDUMP032I JVM requested System dump using '/Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/core.20210813.093848.7042.0001.dmp' in response to an event
EFlags 10602, EFlags & 0x400 = 400, DF flag is set
Unhandled exception
Type=Segmentation error vmState=0x00000000
J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000000
Handler1=000000000B437300 Handler2=000000000AA923C0
RDI=00000000FF8B7B98 RSI=00000000FF8B7B94 RAX=00000000FF8B7B48 RBX=00000000FF95D1A8
RCX=000000000000000F RDX=0000000000000020 R8=0000000000000022 R9=0000000000000000
R10=00000000000DF92C R11=0000000000000622 R12=00000000FF95C9B0 R13=00000000FF8F5D10
R14=00000000FF8B7B48 R15=00000000FF974FC0
RIP=00000000229E6F2D GS=0000 FS=0000 RSP=000000000D909BB0
RFlags=0000000000010602 CS=002B RBP=000000000D909E00 ERR=7711472000000000
TRAPNO=000000000000000D CPU=4720000000000000 FAULTVADDR=00007FFF77114720
XMM0 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM1 000000000d909c20 (f: 227580960.000000, d: 1.124399e-315)
XMM2 00000000df000000 (f: 3741319168.000000, d: 1.848457e-314)
XMM3 0000000000000013 (f: 19.000000, d: 9.387247e-323)
XMM4 00000000ff974fc0 (f: 4288106496.000000, d: 2.118606e-314)
XMM5 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM6 3fdf6123fa7028ac (f: 4201654528.000000, d: 4.903040e-01)
XMM7 402e7f9c1e980fa9 (f: 513281952.000000, d: 1.524924e+01)
XMM8 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM10 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM11 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM15 0000000000000000 (f: 0.000000, d: 0.000000e+00)

Compiled_method=j9vm/test/arraycopy/MultiThreadedBackwardArrayCopyTest.rotateSource()V
Target=2_90_20210813_127 (Mac OS X 10.11.6)
CPU=amd64 (4 logical CPUs) (0x200000000 RAM)
----------- Stack Backtrace -----------
---------------------------------------
JVMDUMP039I Processing dump event "gpf", detail "" at 2021/08/13 09:38:50 - please wait.
JVMDUMP010I System dump written to /Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/core.20210813.093848.7042.0001.dmp
JVMDUMP032I JVM requested Java dump using '/Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/javacore.20210813.093848.7042.0003.txt' in response to an event
JVMDUMP010I Java dump written to /Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/javacore.20210813.093848.7042.0003.txt
JVMDUMP032I JVM requested Snap dump using '/Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/Snap.20210813.093848.7042.0004.trc' in response to an event
JVMDUMP010I Snap dump written to /Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/Snap.20210813.093848.7042.0004.trc
JVMDUMP032I JVM requested JIT dump using '/Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/jitdump.20210813.093848.7042.0005.dmp' in response to an event
JVMDUMP051I JIT dump occurred in 'Thread-3' thread 0x000000000D8B1600
JVMDUMP053I JIT dump is recompiling j9vm/test/arraycopy/MultiThreadedBackwardArrayCopyTest.rotateSource()V
JVMDUMP053I JIT dump is recompiling j9vm/test/arraycopy/MultiThreadedBackwardArrayCopyTest.rotateSource()V
JVMDUMP010I JIT dump written to /Users/jenkins/workspace/Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/output_16288547809972/J9vmTest_5/jitdump.20210813.093848.7042.0005.dmp
JVMDUMP013I Processed dump event "gpf", detail "".
no-zero exit value: 255
*** Test FAILED *** (j9vm.test.arraycopy.MultiThreadedBackwardArrayCopyTest)

@a7ehuo a7ehuo force-pushed the set-aladd-aiadd-internalPtr branch from 6ce3054 to cd7ef40 Compare October 14, 2021 18:31
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Oct 15, 2021

@0xdaryl Could you help relaunch PR build test? The above failure was due to known issues. I also rebased this PR to the latest master.

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 15, 2021

Jenkins test sanity all jdk17

@pshipton
Copy link
Member

PR builds aren't going to work until artifactory is fixed.

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 15, 2021

Jenkins test sanity all jdk17

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 15, 2021

The macOS crash in the interpreter is real and not one I've seen before. I don't believe your changes are responsible, but an issue should be opened nonetheless and the failing test re-run:

Testing: -Xlockword minimizeFootprint mode
Test start time: 2021/10/15 15:10:18 Atlantic Standard Time
Running command: "/Users/jenkins/workspace/Test_openjdk17_j9_sanity.functional_x86-64_mac_Personal_testList_1/openjdkbinary/j2sdk-image/bin/java"   -Xdump -cp "/Users/jenkins/workspace/Test_openjdk17_j9_sanity.functional_x86-64_mac_Personal_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/utils/utils.jar" -Xlockword:mode=minimizeFootprint VMBench.FibBench
Time spent starting: 2 milliseconds
Time spent executing: 2904 milliseconds
Test result: FAILED
Output from test:
 [OUT] Fibonacci: iterations = 10000
 [OUT] fibonacci(12) = 144
 [ERR] Unhandled exception
 [ERR] Type=Segmentation error vmState=0x00000000
 [ERR] J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
 [ERR] Handler1=000000001148C2D0 Handler2=000000001174ED80 InaccessibleAddress=0000000000000024
 [ERR] RDI=000000001F61F400 RSI=00007000057A0288 RAX=0000000000000004 RBX=00007FBD15008C20
 [ERR] RCX=000000001F715138 RDX=000000001F61F400 R8=00000007FFEE41D0 R9=00007FBD14071868
 [ERR] R10=0000000000000000 R11=0000000044748D87 R12=0000000000000000 R13=FFFFFFFFFFFFFFFF
 [ERR] R14=0000000000000000 R15=000000001F715160
 [ERR] RIP=00000000114EB84D GS=0000 FS=0000 RSP=00007000057A0000
 [ERR] RFlags=0000000000010202 CS=002B RBP=00007000057A0270 ERR=0000002400000004
 [ERR] TRAPNO=000000040000000E CPU=0024000000040000 FAULTVADDR=0000000000000024
 [ERR] XMM0 ffffffffffffffff (f: 4294967296.000000, d: nan)
 [ERR] XMM1 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] XMM2 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] XMM3 3df3746abb09eb74 (f: 3137989376.000000, d: 2.831039e-10)
 [ERR] XMM4 3e9e17bc1e41c36f (f: 507626336.000000, d: 4.484164e-07)
 [ERR] XMM5 0000000000100000 (f: 1048576.000000, d: 5.180654e-318)
 [ERR] XMM6 3fd3772662bfd85b (f: 1656739968.000000, d: 3.041473e-01)
 [ERR] XMM7 402e7f9c1e980fa9 (f: 513281952.000000, d: 1.524924e+01)
 [ERR] XMM8 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] XMM9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] XMM10 0000000000000006 (f: 6.000000, d: 2.964394e-323)
 [ERR] XMM11 0000000000000008 (f: 8.000000, d: 3.952525e-323)
 [ERR] XMM12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] XMM13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] XMM14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] XMM15 0000000000000000 (f: 0.000000, d: 0.000000e+00)
 [ERR] Module=/Users/jenkins/workspace/Test_openjdk17_j9_sanity.functional_x86-64_mac_Personal_testList_1/openjdkbinary/j2sdk-image/lib/default/libj9vm29.dylib
 [ERR] Module_base_address=0000000011454000 Symbol=_ZN32VM_BytecodeInterpreterCompressed3runEP10J9VMThread
 [ERR] Symbol_address=00000000114DFB90

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Oct 15, 2021

The crash from Test_openjdk17_j9_sanity.functional_x86-64_mac_Personal 23 is in cmdLineTest_J9test_common_0 (Testing: -Xlockword:mode=minimizeFootprint VMBench.FibBench). Looks similar to #13577

1XMCURTHDINFO  Current thread
3XMTHREADINFO      "main" J9VMThread:0x000000001F61F400, omrthread_t:0x00007FBD15003450, java/lang/Thread:0x00000007FFE0A360, state:R, prio=5
3XMJAVALTHREAD            (java/lang/Thread getId:0x1, isDaemon:false)
3XMTHREADINFO1            (native thread ID:0x2FF06D6A, native priority:0x5, native policy:UNKNOWN, vmstate:R, vm thread flags:0x00000020)
3XMTHREADINFO2            (native stack address range from:0x0000700005721000, to:0x00007000057A1000, size:0x80000)
3XMCPUTIME               CPU usage total: 0.149364000 secs, current category="Application"
3XMHEAPALLOC             Heap bytes allocated since last GC cycle=359920 (0x57DF0)
3XMTHREADINFO3           Java callstack:
4XESTACKTRACE                at jdk/internal/misc/Unsafe.putInt(Native Method)
4XESTACKTRACE                at com/ibm/jit/JITHelpers.putIntInObject(JITHelpers.java:286)
4XESTACKTRACE                at com/ibm/jit/JITHelpers.unsafeObjectShallowCopy64(JITHelpers.java:807)
4XESTACKTRACE                at java/lang/invoke/MemberName.clone(MemberName.java:752(Compiled Code))
4XESTACKTRACE                at java/lang/invoke/MemberName$Factory.resolve(MemberName.java:1067(Compiled Code))
4XESTACKTRACE                at java/lang/invoke/MemberName$Factory.resolveOrFail(MemberName.java:1114(Compiled Code))
4XESTACKTRACE                at java/lang/invoke/InvokerBytecodeGenerator.resolveInvokerMember(InvokerBytecodeGenerator.java:327)
4XESTACKTRACE                at java/lang/invoke/InvokerBytecodeGenerator.loadMethod(InvokerBytecodeGenerator.java:321)
4XESTACKTRACE                at java/lang/invoke/InvokerBytecodeGenerator.generateCustomizedCode(InvokerBytecodeGenerator.java:751)
4XESTACKTRACE                at java/lang/invoke/LambdaForm.compileToBytecode(LambdaForm.java:854)
4XESTACKTRACE                at java/lang/invoke/LambdaForm.prepare(LambdaForm.java:812)
4XESTACKTRACE                at java/lang/invoke/MethodHandle.<init>(MethodHandle.java:481)
4XESTACKTRACE                at java/lang/invoke/BoundMethodHandle.<init>(BoundMethodHandle.java:56)
4XESTACKTRACE                at java/lang/invoke/BoundMethodHandle$Species_L.<init>(BoundMethodHandle.java:222)
4XESTACKTRACE                at java/lang/invoke/BoundMethodHandle$Species_L.copyWith(BoundMethodHandle.java:242)
4XESTACKTRACE                at java/lang/invoke/MethodHandles.dropArguments0(MethodHandles.java:5275)
4XESTACKTRACE                at java/lang/invoke/MethodHandles.dropArguments(MethodHandles.java:5338)
4XESTACKTRACE                at java/lang/invoke/StringConcatFactory.generateMHInlineCopy(StringConcatFactory.java:519)
4XESTACKTRACE                at java/lang/invoke/StringConcatFactory.makeConcatWithConstants(StringConcatFactory.java:363)
4XESTACKTRACE                at java/lang/invoke/LambdaForm$DMH/0x000000001701e820.invokeStatic(LambdaForm$DMH)
4XESTACKTRACE                at java/lang/invoke/LambdaForm$MH/0x000000001701f420.delegate(LambdaForm$MH)
4XESTACKTRACE                at java/lang/invoke/LambdaForm$MH/0x0000000017020420.invokeExact_MT(LambdaForm$MH)
4XESTACKTRACE                at java/lang/invoke/BootstrapMethodInvoker.invoke(BootstrapMethodInvoker.java:144)
4XESTACKTRACE                at java/lang/invoke/CallSite.makeSite(CallSite.java:315)
4XESTACKTRACE                at java/lang/invoke/MethodHandleNatives.linkCallSiteImpl(MethodHandleNatives.java:281)
4XESTACKTRACE                at java/lang/invoke/MethodHandleNatives.linkCallSite(MethodHandleNatives.java:271)
4XESTACKTRACE                at java/lang/invoke/MethodHandleResolver.resolveInvokeDynamic(MethodHandleResolver.java:194)
4XESTACKTRACE                at VMBench/FibBench.main(FibBench.java:47)
3XMTHREADINFO3           No native callstack available for this thread

@0xdaryl
Copy link
Contributor

0xdaryl commented Oct 18, 2021

Jenkins test sanity osx jdk17

@0xdaryl 0xdaryl merged commit 49e674a into eclipse-openj9:master Oct 18, 2021
@a7ehuo a7ehuo deleted the set-aladd-aiadd-internalPtr branch January 12, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

@0xdaryl 0xdaryl 0xdaryl approved these changes

Assignees

@0xdaryl 0xdaryl

Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7ehuo @0xdaryl @pshipton @hzongaro