-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove java.lang.Compiler from Java 21+ #18571
Conversation
Fixes: eclipse-openj9#18430 Signed-off-by: Keith W. Campbell <[email protected]>
There is more to do, not sure if you want to keep #18430 open for this. core-libs/java.lang The system property java.compiler has been removed from the list of standard system properties. Running with this system property set on the command line will now print a warning to say that the system property is obsolete; it has no other effect. In previous releases, running with -Djava.compiler or -Djava.compiler=NONE on the command line selected interpreter only execution mode. If needed, the -Xint option can be used to run in interpreter only mode. |
Let's keep #18430 open for those other tasks. |
jenkins test sanity,extended amac jdk11 depends ibmruntimes/openj9-openjdk-jdk11#736 |
jenkins test sanity,extended amac jdk21 depends ibmruntimes/openj9-openjdk-jdk21#86 |
Something is wrong. |
I guess testing doesn't pick up the proper extensions, I'll need to use a grinder to test it properly. |
jenkins compile win,aix jdk8 |
Actually the functional testing doesn't use the extensions afaik. The access library is in the test image, so I'm not sure what is wrong. |
I think I missed adding |
Add CompilerAccess to allow tests to compile in Java 21+, supported by new "access" test shared library. Update tests to use the new library as needed, and defining TEST_LIB_PATH for DDR tests on OSX. Signed-off-by: Keith W. Campbell <[email protected]>
Updated a few playlist.xml files to fix failing tests; tests that need native libraries must also define |
We'll see if any others are missing in the nightly builds tonight. |
After we see if anything else is missing, we'll need PRs for 0.42 and 0.43. |
More If anyone is searching, these errors are a known test problem that will be resolved shortly. |
Update tests to avoid using java.lang.Compiler directly.
Issue: #18430.
Depends on changes to extension repositories to include new shared library in test-image:
Those changes can safely be merged before this because libraries are only include in test-image if they exist.