Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java.lang.Compiler from Java 21+ #18571

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

keithc-ca
Copy link
Contributor

@keithc-ca keithc-ca commented Dec 6, 2023

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

There is more to do, not sure if you want to keep #18430 open for this.

core-libs/java.lang
Removal of the java.compiler System Property (JDK-8041676)

The system property java.compiler has been removed from the list of standard system properties.

Running with this system property set on the command line will now print a warning to say that the system property is obsolete; it has no other effect. In previous releases, running with -Djava.compiler or -Djava.compiler=NONE on the command line selected interpreter only execution mode. If needed, the -Xint option can be used to run in interpreter only mode.

@keithc-ca
Copy link
Contributor Author

Let's keep #18430 open for those other tasks.

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

jenkins test sanity,extended amac jdk11 depends ibmruntimes/openj9-openjdk-jdk11#736

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

jenkins test sanity,extended amac jdk21 depends ibmruntimes/openj9-openjdk-jdk21#86

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

Something is wrong.

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

I guess testing doesn't pick up the proper extensions, I'll need to use a grinder to test it properly.

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

jenkins compile win,aix jdk8

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

I guess testing doesn't pick up the proper extensions, I'll need to use a grinder to test it properly.

Actually the functional testing doesn't use the extensions afaik. The access library is in the test image, so I'm not sure what is wrong.

@keithc-ca
Copy link
Contributor Author

I think I missed adding $(ADD_JVM_LIB_DIR_TO_LIBPATH) in some playlists.

Add CompilerAccess to allow tests to compile in Java 21+, supported
by new "access" test shared library. Update tests to use the new
library as needed, and defining TEST_LIB_PATH for DDR tests on OSX.

Signed-off-by: Keith W. Campbell <[email protected]>
@keithc-ca
Copy link
Contributor Author

Updated a few playlist.xml files to fix failing tests; tests that need native libraries must also define TEST_LIB_PATH for OSX.
Tests (using the JDK built in https://openj9-jenkins.osuosl.org/job/Build_JDK21_aarch64_mac_Personal/70) that failed earlier now pass; see https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3099.

@pshipton pshipton merged commit d5dea53 into eclipse-openj9:master Dec 6, 2023
@keithc-ca keithc-ca deleted the compiler branch December 6, 2023 22:05
@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

We'll see if any others are missing in the nightly builds tonight.

@pshipton
Copy link
Member

pshipton commented Dec 6, 2023

After we see if anything else is missing, we'll need PRs for 0.42 and 0.43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants