-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pyproject toml #729
Migrate pyproject toml #729
Conversation
Co-authored-by: Christian Clauss <[email protected]>
@ralight Your review please. |
@cclauss What's the game plan with regard to the lint_python pytest failures in GHA? AFAICS these are nothing to do with anything I've changed as part of this PR and I'm not best placed to resolve them? |
Is this repo still actively maintained? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution. Could you add a Signed-Off to your commit ? This is a requirement from Eclipse to acknowledge you agree with the ECA.
redundant/setup.cfg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could drop this file, couldn't we ? I don't see reason to kept them.
redundant/tox.ini
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without tox, how do we run linters ? I want to kept the ability to run linters & tests locally and not only relying on Github actions.
With tox, I only need to run two commands: tox -e py
and tox -e lint
. Everything was handled:
- creation of virtualenv, installation of dependency
- running test and linters command (for linters it's valuable, since we have multiple linters)
tox might not be the best tool for this usecase (here we don't use tox for it's ability to run on multiple Python versions, I use different Docker containers for that) that but it works and it's a well-known tools. I think we should kept it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without tox, how do we run linters ?
One common option is https://pre-commit.com/ which can also be easily run in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be best to upgrade to pre-commit to automate the fast tests like ruff, codespell, black.
sorry no longer have the bandwidth to progress this |
@akx Given that both @semuadmin and I have both closed our PRs, perhaps you can jump in with your automated tool for creating these PRs. |
@cclauss I don't have an automated tool per se - |
setup.py is now deprecated and is scheduled to be dropped altogether in pip 23.
This PR makes a number of changes to update the project build framework:
NB: this PR only changes the build setup - no changes have been made to existing application code or test cases, so some existing CI workflows may still fail if they were failing previously.
Fixes #706