Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with coverage reporting #782

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Run tests with coverage reporting #782

merged 2 commits into from
Jan 10, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Dec 24, 2023

Fixes #775.

@akx akx marked this pull request as ready for review December 24, 2023 19:01
@akx
Copy link
Contributor Author

akx commented Dec 24, 2023

Things seem to work: https://app.codecov.io/github/eclipse/paho.mqtt.python/pull/782/tree

@PierreF Would you like me to see if we can get the coverage% as a GitHub comment without an external service?

If we want Codecov to comment on the PRs, someone admin enough on eclipse will need to enable this repo on https://app.codecov.io/ .

@akx akx marked this pull request as draft December 25, 2023 08:45
akx added 2 commits December 27, 2023 09:22
Signed-off-by: Aarni Koskela <[email protected]>
Signed-off-by: Aarni Koskela <[email protected]>
@akx akx marked this pull request as ready for review December 27, 2023 07:46
@PierreF
Copy link
Contributor

PierreF commented Dec 31, 2023

I think codecov could be fine, it seems already used by few other project from Eclipse.

@akx did you know which "admin enough" right are needed ? @icraggs do you know who to ask for (if not you).

@akx
Copy link
Contributor Author

akx commented Dec 31, 2023

@PierreF Presumably someone who can see eclipse on https://github.com/apps/codecov/installations/select_target :)

@icraggs
Copy link

icraggs commented Jan 9, 2024

Ok, I think I've done everything needed. Let me know if not.

@PierreF
Copy link
Contributor

PierreF commented Jan 9, 2024

@akx I've re-run one of the tox job. Should we expect something on this PR or should I merge it and we should see it on future PR ?

@akx
Copy link
Contributor Author

akx commented Jan 10, 2024

@PierreF I think hopefully we'll see Codecov comment in a subsequent PR after this gets merged :) Thanks!

@PierreF PierreF merged commit 2eb5350 into eclipse-paho:master Jan 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: enable code coverage tracking
3 participants