-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade InvenioRDM to v12 and improve M1 Mac Compatibility #389
base: main
Are you sure you want to change the base?
Conversation
Thanks @tmorrell for taking the time to test the We've reviewed the PR, and we have a few questions/comments. We know you have already spent time with this effort, and we don't want to take any more of your time unless you would like to continue. Let us know if you like to put more time on the PR, or should we take it over and shepherd it into the codebase (we should be able to retain your commits). Review questions/comments:
|
@tmorrell When you get a minute, please enable maintainer permissions on this PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests We are going to go ahead and make the changes noted in the review comment to merge this PR, and we want to use this PR so we can retain your commits. |
@tmorrell don't worry about this, I was able to cherry pick your commits. I will be opening another PR with your commits and a couple other changes. |
This pull request upgrades InvenioRDM to the current version v12. The setup is based on https://github.com/inveniosoftware/cookiecutter-invenio-rdm and a couple of tweaks to get it working integrated with pass. I was able to sort out the docker networking issues, so this is a fully working example.
It also adds the platform to the docker compose files, which is needed on M1 macs.