-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the e4 view created by PDE template closable #196
Conversation
Do we have a freeze day today? I did not see an email for that. |
@laeubi something seems wrong with the new API parser, works fine on GH action for Ubuntu but not on Windows. |
This sadly is an issue with: so let the peoples there know this is an issue and ask for a fix :-) |
Not sure what the exact issue is, so I leave that to you as you worked on this. Maybe we should disable the verifcation GH build on Windows until this is fixed? |
This currently only affects the upload of the test results, so I think it is still useful. |
What's the status here? Can this be submitted? |
The currently contributed part is not closable which is not a typical behavior for contributed parts.
Yes, IIRC tests were failing before but I think these were unrelated. |
I think normally there were 349 tests failing... |
Just the "usual" test failures. |
The currently contributed part is not closable which is not a typical
behavior for contributed parts.