Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiAnalysisApplication should wait until jobs are done #710

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Aug 16, 2023

As part of the build probabbly other jobs are sceduled, the ApiAnalysisApplication should wait for all jobs to complete before investigate error markers to prevent problems with outdated states.

Currently the ApiAnalysisApplication seem flaky as discovered here:

@HannesWell @vik-chand please give approval for M3 this should not affect any IDE users but can improve the situation for Tycho users.

As part of the build probabbly other jobs are sceduled, the
ApiAnalysisApplication should wait for all jobs to complete before
investigate error markers to prevent problems with outdated states.
@laeubi laeubi requested review from vik-chand and HannesWell August 16, 2023 07:37
@github-actions
Copy link

Test Results

     246 files  ±0       246 suites  ±0   54m 16s ⏱️ - 4m 29s
  3 299 tests ±0    3 273 ✔️  - 1  24 💤 ±0  0 ±0  2 🔥 +1 
10 194 runs  ±0  10 120 ✔️  - 1  72 💤 ±0  0 ±0  2 🔥 +1 

For more details on these errors, see this check.

Results for commit f2470bb. ± Comparison against base commit 2293b21.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to submit.

this should not affect any IDE users but can improve the situation for Tycho users.

Yes, I only know Tycho as user of the APIAnalyisApplication.

@laeubi laeubi merged commit c71d0c1 into eclipse-pde:master Aug 16, 2023
@HannesWell HannesWell added this to the 4.29 M3 milestone Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants