-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debian stable based image to build swt natives #2441
Conversation
Can you build swt gtk4 on it ? I don't think doing any switch that doesn't allow that is worth the effort. |
No gtk4 will require debian-stable (not old stable), but this will raise the Glibc requirement considerably..
We currently build on an image we can't actively change nor can get any patches anymore, we can't build it even in the current state. So my fist goal would be to get into a working state again where we have the chance to update. |
Please note that changing the image may raise in some other way (glibc/cairo/.....) and introduce breakage (and extra work - e.g. simrel projects no longer build and test with default image centos) while there is no gain from it. I don't mind the change in principle just looking for some benefit when introducing potential extra work. |
That's why I previously waited for the |
BTW oldstable is currently GLIBC 2.31-13 |
81d533c
to
2cee6bf
Compare
I now moved to debian-stable what supports gtk4 (4.8.3) and uses glibc 2.36-9 with that I can compile the GTK4 binaries when apply this PR: |
FWIW, binaries produced that way will run just fine on distro having GTK 4.10+ e.g. Ubuntu 24.04 so it is a good first step. |
Currently we build the swt natives with centos-8 but this is now gone, also centos-9 no longer provides stable releases but only rolling-streams, This adds a new container based on debian stable and only adds the absolute minimum required to build the swt natives. Why Debian: Debian offers quite conservative dependencies and LTS releases so there is a good chance to have a common baseline that works on more ahead distributions as well (e.g. GClib /GTK/... versions).
2cee6bf
to
a711ff1
Compare
Unluckily the push fails, I created: |
The image 'platformreleng-centos-swt-build:8' cannot be built anymore and is therefore not updated. Align with SWT and use the debian-12 image instead. This will increase the GLIBC version requirement to version 2.34, see eclipse-platform/eclipse.platform.swt#1422 (comment) See also eclipse-platform/eclipse.platform.releng.aggregator#2441
The image 'platformreleng-centos-swt-build:8' cannot be built anymore and is therefore not updated. Align with SWT and use the debian-12 image instead. This will increase the GLIBC version requirement to version 2.34, see eclipse-platform/eclipse.platform.swt#1422 (comment) See also eclipse-platform/eclipse.platform.releng.aggregator#2441
The image 'platformreleng-centos-swt-build:8' cannot be built anymore and is therefore not updated. Align with SWT and use the debian-12 image instead. This will increase the GLIBC version requirement to version 2.34, see eclipse-platform/eclipse.platform.swt#1422 (comment) See also eclipse-platform/eclipse.platform.releng.aggregator#2441
Currently we build the swt natives with centos-8 but this is now gone,
also centos-9 no longer provides stable releases but only
rolling-streams,
This adds a new container based on debian stable and only adds the
absolute minimum required to build the swt natives.
Why Debian:
Debian offers quite conservative dependencies and LTS releases
so there is a good chance to have a common baseline that works on
more ahead distributions as well (e.g. GClib /GTK/... versions).