[FS] Copy small files using InputStream.transferTo() #1502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1471 to not use
java.nio.file.Files.copy()
for small files because it's slower in that case.With #1475
InputStream.transferTo()
is used, which is optimized from Java-17 to 21 in case aFileInputStream
is transferred to aFileOutputStream
to perform the copy usingFileChannel
s.In my experiments the latter method and
Files.copy()
had approximately similar performance in the area of 1MiB large files, whileFiles.copy()
became faster with further growing file-size and was significantly faster for 1GiB files.Since Eclipse-Platform probably requires Java-21 soonish, using 1MiB as threshold seemed to be a good compromise for me.