Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved features to own page, added ToC to pages #30

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

jbicker
Copy link
Contributor

@jbicker jbicker commented Jan 9, 2024

Added Table of contents to each page (except Getting Started because there is such kind of ToC in the abstract).
Additionally the list of features were moved to their own page because it felt like this is a topic worth its own page.

@jbicker jbicker temporarily deployed to pull-request-preview January 9, 2024 16:29 — with GitHub Actions Inactive
Copy link

github-actions bot commented Jan 9, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-12 10:46 UTC

@gfontorbe
Copy link
Contributor

Thanks Jan, just one suggestion:
Do we want to also put the different SModel elements in the TOC or is that too much?

@jbicker
Copy link
Contributor Author

jbicker commented Jan 11, 2024

Thanks Jan, just one suggestion: Do we want to also put the different SModel elements in the TOC or is that too much?

That was actually a lot / too much. So I decided to show the first level only.

Copy link
Contributor

@gfontorbe gfontorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@gfontorbe gfontorbe merged commit 4e35431 into eclipse-sprotty:main Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants