-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to reject request actions #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I wonder whether we should by default allow an error JSON object in addition to the message, similar to console.log()
I thought about that, too, but what type should we use? |
Not |
I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
It should be possible to reject request actions. This change introduces RejectAction for this purpose.
This is particularly important for requests that are forwarded to a diagram server, e.g. RequestModelAction. We should implement the new feature in sprotty-server, too, after this is merged.