-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lang): Add multiple languages configuration #26
feat(lang): Add multiple languages configuration #26
Conversation
defc86d
to
182182f
Compare
Hi @heliocastro, |
Yes, you add the exception on the .licencerc.yaml config file. Please add common.json there |
7b98439
to
a4a1de6
Compare
Thanks. But in my opinion, we should keep package-lock.json in our repository. It's recommended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a4a1de6
to
48b0ec9
Compare
Signed-off-by: hoangnt2 <[email protected]>
@heliocastro, I think it's not easy to change to App router now. I will research your reference and try to do it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Refer issue: #25
Some changes
Add multiple languages configuration (use next-i18next):
Login page with English language
Login page with Japanese language
Move login page from /auth to /
Move home page from / to /home
Remove unnecessary component: PublicContextProvider
Change Environment variable from SW360_API_URL to NEXT_PUBLIC_SW360_API_URL (can be used on client side)
How to test
Prerequisite
Procedures
Result