-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): modify moderation requests #1889
Merged
heliocastro
merged 1 commit into
eclipse-sw360:main
from
siemens:feat/api/moderationRequest-accept
Jun 6, 2023
Merged
feat(rest): modify moderation requests #1889
heliocastro
merged 1 commit into
eclipse-sw360:main
from
siemens:feat/api/moderationRequest-accept
Jun 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
added
WIP
work in progress
needs code review
REST
New-UI
Level for the API and UI level changes for the new-ui
labels
Mar 29, 2023
GMishx
changed the title
Feat/api/moderation request accept
feat(rest): modify moderation requests
Mar 29, 2023
GMishx
force-pushed
the
feat/api/moderationRequest-accept
branch
from
April 7, 2023 11:57
0daf18b
to
0e10fd3
Compare
GMishx
force-pushed
the
feat/api/moderationRequest-accept
branch
2 times, most recently
from
May 11, 2023 15:50
f969681
to
5e035d6
Compare
ag4ums
added
the
needs general test
This is general testing, meaning that there is no org specific issue to check for
label
May 17, 2023
Things that I found while testing,
|
GMishx
force-pushed
the
feat/api/moderationRequest-accept
branch
2 times, most recently
from
May 22, 2023 10:47
54c5664
to
9b4aa34
Compare
GMishx
force-pushed
the
feat/api/moderationRequest-accept
branch
from
May 25, 2023 08:43
9b4aa34
to
7a9ee03
Compare
Added an exception handler for the same @rudra-superrr . Also, blocked all calls to closed MRs. Please have a look |
Testing was successful. |
rudra-superrr
removed
the
needs general test
This is general testing, meaning that there is no org specific issue to check for
label
May 26, 2023
Modify ModerationRequest being - Accepted - Rejected - Assigned (In progress) - Unassigned (Pending) Commit is related to issue eclipse-sw360#1849 Signed-off-by: Gaurav Mishra <[email protected]>
GMishx
force-pushed
the
feat/api/moderationRequest-accept
branch
from
May 31, 2023 05:55
7a9ee03
to
0481e60
Compare
Code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds new HTTP verbs to endpoint
/moderationrequest
to modify ModerationRequests from REST API.Issue: #1849
Suggest Reviewer
How To Test?
Create several moderation requests to perform following actions on the endpoint.
PATCH
/moderationrequest/{id}
action
asACCEPT
in body and somecomment
, the request should accept the MR.PATCH
/moderationrequest/{id}
action
asREJECT
in body and somecomment
, the request should reject the MR.PATCH
/moderationrequest/{id}
action
asASSIGN
in body, the request should assign the MR to the caller and set the status to "in progress".PATCH
/moderationrequest/{id}
action
asASSIGN
in body, for a MR where caller is not a moderator should throw error.PATCH
/moderationrequest/{id}
action
asUNASSIGN
in body, the request should remove the caller from the moderator list of the MR and set the status to "pending".PATCH
/moderationrequest/{id}
action
asUNASSIGN
in body, for a MR with only one moderator should throw error.REST documentation tests.
Checklist
Must: