Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): new endpoint /mySubmissions #2271

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jan 16, 2024

New endpoint /moderationrequest/mySubmissions to get moderation requests submitted by the user.

Also, refactor the ModerationRequestController to use ModerationRequestController.getModerationResponseEntity()

Closes #1849

Issue: #1849

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

  1. Check the docs for the new endpoint.
  2. Check moderation request matches the "My Task Submissions" list from SW360 Homepage.

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@GMishx GMishx added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for New-UI Level for the API and UI level changes for the new-ui labels Jan 16, 2024
@GMishx GMishx added the REST label Jan 16, 2024
@rudra-superrr rudra-superrr self-assigned this Jan 30, 2024
@rudra-superrr
Copy link
Contributor

Testing was successful.

image
image

@rudra-superrr rudra-superrr removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Jan 31, 2024
@rudra-superrr
Copy link
Contributor

Can you add one more parameter i.e. sort, so that mySubmissions can be sorted on the basis of status and document name.

@GMishx GMishx force-pushed the feat/api/task-assignment branch from 985c4af to ed7e431 Compare February 20, 2024 09:17
@GMishx
Copy link
Member Author

GMishx commented Feb 20, 2024

@rudra-superrr , I've added the comparators so the sorting should work. Have also documented the sort parameter for OpenAPI and spring doc. Please check.

@rudra-superrr
Copy link
Contributor

Looks good to me.

New endpoint `/moderationrequest/mySubmissions` to get moderation
requests submitted by the user.

Also, refactor the `ModerationRequestController` to use
`ModerationRequestController.getModerationResponseEntity()`

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx GMishx force-pushed the feat/api/task-assignment branch from ed7e431 to 14fda71 Compare February 25, 2024 08:31
@GMishx GMishx removed their assignment Feb 25, 2024
@ag4ums ag4ums merged commit 48ca00a into eclipse-sw360:main Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge REST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API for Moderation request
3 participants