[core] fix leaking DisposableCollection.onDispose event

Signed-off-by: Anton Kosyakov <[email protected]>
eclipse-theia · Apr 7, 2020 · 2bb5dd9 · 2bb5dd9
1 parent 710c17b
commit 2bb5dd9
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/core/src/common/disposable.ts b/packages/core/src/common/disposable.ts
@@ -44,13 +44,18 @@ export class DisposableCollection implements Disposable {
         toDispose.forEach(d => this.push(d));
     }
 
+    /**
+     * This event is fired only once
+     * on first dispose of not empty collection.
+     */
     get onDispose(): Event<void> {
         return this.onDisposeEmitter.event;
     }
 
     protected checkDisposed(): void {
         if (this.disposed && !this.disposingElements) {
             this.onDisposeEmitter.fire(undefined);
+            this.onDisposeEmitter.dispose();
         }
     }