plugin: align breakpoint api

The commit aligns the signature of both `addBreakpoints` and `removeBreakpoints` to the expecations of the VS Code API. Signed-off-by: vince-fugnitto <[email protected]>
eclipse-theia · Mar 23, 2022 · 4ade592 · 4ade592
1 parent 7a44ee6
commit 4ade592
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/plugin-ext/src/plugin/node/debug/debug.ts b/packages/plugin-ext/src/plugin/node/debug/debug.ts
@@ -132,7 +132,7 @@ export class DebugExtImpl implements DebugExt {
         return this.onDidChangeBreakpointsEmitter.event;
     }
 
-    addBreakpoints(breakpoints: theia.Breakpoint[]): void {
+    addBreakpoints(breakpoints: readonly theia.Breakpoint[]): void {
         const added: theia.Breakpoint[] = [];
         for (const b of breakpoints) {
             if (this._breakpoints.has(b.id)) {
@@ -147,7 +147,7 @@ export class DebugExtImpl implements DebugExt {
         }
     }
 
-    removeBreakpoints(breakpoints: theia.Breakpoint[]): void {
+    removeBreakpoints(breakpoints: readonly theia.Breakpoint[]): void {
         const removed: theia.Breakpoint[] = [];
         const removedIds: string[] = [];
         for (const b of breakpoints) {

diff --git a/packages/plugin-ext/src/plugin/plugin-context.ts b/packages/plugin-ext/src/plugin/plugin-context.ts
@@ -853,10 +853,10 @@ export function createAPIFactory(
             stopDebugging(session?: theia.DebugSession): Thenable<void> {
                 return debugExt.stopDebugging(session);
             },
-            addBreakpoints(breakpoints: theia.Breakpoint[]): void {
+            addBreakpoints(breakpoints: readonly theia.Breakpoint[]): void {
                 debugExt.addBreakpoints(breakpoints);
             },
-            removeBreakpoints(breakpoints: theia.Breakpoint[]): void {
+            removeBreakpoints(breakpoints: readonly theia.Breakpoint[]): void {
                 debugExt.removeBreakpoints(breakpoints);
             }
         };

diff --git a/packages/plugin/src/theia.d.ts b/packages/plugin/src/theia.d.ts
@@ -10056,14 +10056,14 @@ export module '@theia/plugin' {
          * @param breakpoints The breakpoints to add.
          */
         // eslint-disable-next-line @typescript-eslint/no-shadow
-        export function addBreakpoints(breakpoints: Breakpoint[]): void;
+        export function addBreakpoints(breakpoints: readonly Breakpoint[]): void;
 
         /**
          * Remove breakpoints.
          * @param breakpoints The breakpoints to remove.
          */
         // eslint-disable-next-line @typescript-eslint/no-shadow
-        export function removeBreakpoints(breakpoints: Breakpoint[]): void;
+        export function removeBreakpoints(breakpoints: readonly Breakpoint[]): void;
     }
 
     /**