Skip to content

Commit

Permalink
[mobile] Prevent the IDE from scrolling along with the text (e.g. on …
Browse files Browse the repository at this point in the history
…iPad)

Ref: #3557

Co-authored-by: Vincent Fugnitto <[email protected]>
Signed-off-by: Jan Keromnes <[email protected]>
  • Loading branch information
2 people authored and akosyakov committed Jul 24, 2019
1 parent f36c151 commit 8114667
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- [plugin] Fixed `Converting circular structure to JSON` Error [#5661](https://github.com/theia-ide/theia/pull/5661)
- [plugin] fixed auto detection of new languages [#5753](https://github.com/theia-ide/theia/issues/5753)
- [vscode] unzip node_modules for built-in extensions [#5756](https://github.com/theia-ide/theia/pull/5756)
- [core] prevent the IDE from scrolling along with the text on mobile (e.g. on iPad) [#5742](https://github.com/theia-ide/theia/pull/5742)

Breaking changes:

Expand Down
1 change: 1 addition & 0 deletions packages/core/src/browser/frontend-application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export class FrontendApplication {
});
window.addEventListener('resize', () => this.shell.update());
document.addEventListener('keydown', event => this.keybindings.run(event), true);
document.addEventListener('touchmove', event => { event.preventDefault(); }, { passive: false });
// Prevent forward/back navigation by scrolling in OS X
if (isOSX) {
document.body.addEventListener('wheel', preventNavigation, { passive: false });
Expand Down

0 comments on commit 8114667

Please sign in to comment.