Skip to content

Commit

Permalink
GH-1530: Fixed the selection/focus issue in the naviagtor.
Browse files Browse the repository at this point in the history
 - I have removed the bugos 'focus' styling.
Focus is only relevant for scrolling and calculating ranges.

 - Fixed the URI discovery in the WS root aware command handler.
It was not adapted to the multi-selection, so it falled back to root.

Closes #1530.

Signed-off-by: Akos Kitta <[email protected]>
  • Loading branch information
kittaakos committed Mar 19, 2018
1 parent 0b426d2 commit 9d560ad
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
8 changes: 0 additions & 8 deletions packages/core/src/browser/style/tree.css
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,6 @@
background: var(--theia-accent-color5);
}

.theia-Tree:focus .theia-TreeNode.theia-mod-focus {
background: var(--theia-accent-color3);
}

.theia-Tree:not(:focus) .theia-TreeNode.theia-mod-focus {
background: var(--theia-accent-color5);
}

.theia-TreeNodeSegment {
flex-grow: 0;
user-select: none;
Expand Down
2 changes: 1 addition & 1 deletion packages/workspace/src/browser/workspace-commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ export class WorkspaceRootUriAwareCommandHandler extends UriAwareCommandHandler<
}

protected getUri(): URI | undefined {
return UriSelection.getUri(this.selectionService.selection) || this.rootUri;
return super.getUri() || this.rootUri;
}

}

0 comments on commit 9d560ad

Please sign in to comment.