Skip to content

Commit

Permalink
[electron] Bind plugin components on the backend
Browse files Browse the repository at this point in the history
The electron inversify container is missing a couple of bindings
required by the whole plugin system to work correctly.

This commit binds what is missing for plugins to function on electron.

Signed-off-by: Paul Maréchal <[email protected]>
  • Loading branch information
paul-marechal authored and akosyakov committed Apr 12, 2019
1 parent d380b17 commit a72ac10
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 2 additions & 4 deletions examples/electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
}
}
},
"//": [
"`@theia/plugin-ext` and `@theia/plugin-ext-vscode` are missing due to https://github.com/theia-ide/theia/issues/3723",
"`@theia/debug`, `@theia/debug-nodejs` and `@theia/java-debug` are removed due to https://github.com/theia-ide/theia/issues/3716"
],
"dependencies": {
"@theia/callhierarchy": "^0.5.0",
"@theia/console": "^0.5.0",
Expand Down Expand Up @@ -44,6 +40,8 @@
"@theia/navigator": "^0.5.0",
"@theia/outline-view": "^0.5.0",
"@theia/output": "^0.5.0",
"@theia/plugin": "^0.5.0",
"@theia/plugin-ext-vscode": "^0.5.0",
"@theia/preferences": "^0.5.0",
"@theia/preview": "^0.5.0",
"@theia/process": "^0.5.0",
Expand Down
2 changes: 2 additions & 0 deletions packages/plugin-ext/src/plugin-ext-backend-electron-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@

import { ContainerModule } from 'inversify';
import { bindElectronBackend } from './hosted/node-electron/plugin-ext-hosted-electron-backend-module';
import { bindMainBackend } from './main/node/plugin-ext-backend-module';

export default new ContainerModule(bind => {
bindMainBackend(bind);
bindElectronBackend(bind);
});

0 comments on commit a72ac10

Please sign in to comment.