Skip to content

Commit

Permalink
repo: drop support for node 10
Browse files Browse the repository at this point in the history
the following commit drops `node v10` support from the framework:
- updates the `engines` tag.
- updates any documentation related to node version.
- updates the CI to drop `node 10` builds.

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto committed Aug 3, 2020
1 parent 747404b commit e7fd33a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
sudo: required
language: node_js
node_js:
- 10
- 12
git:
depth: 1
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

<a name="breaking_changes_1.5.0">[Breaking Changes:](#breaking_changes_1.5.0)</a>

<a name="1_4_0_drop_node_10_support"></a>
- [[repo]](#1_4_0_drop_node_10_support) support for `Node 10` is dropped. [#8290](https://github.com/eclipse-theia/theia/pull/8290)
- From now on, you Node.js `12.x` is required to build Theia from sources.\
The recommended minimum version is aligned with `electron` (Node.js `12.14.1`).
- [output] `OutputWidget#setInput` has been removed. The _Output_ view automatically shows the channel when calling `OutputChannel#show`. Moved the `OutputCommands` namespace from the `output-contribution` to its dedicated `output-commands` module to overcome a DI cycle. [#8243](https://github.com/eclipse-theia/theia/pull/8243)
- [example app] updated yarn.lock so that the latest version of `vscode-ripgrep` is used (`v1.8.0`). This way we can benefit from the recently added support for it using proxy settings when fetching the platform-specific `ripgrep` executable, after npm package install. This should make it a lot easier to build our example application in corporate settings, behind a firewall. [#8280](https://github.com/eclipse-theia/theia/pull/8280)
- Note to downstream IDE designers: this change will not have an effect beyond this repo's example application. If it's desirable for your product to have the latest `vscode-ripgrep`, you should do similarly in your own `yarn.lock`.
Expand Down
6 changes: 2 additions & 4 deletions doc/Developing.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,8 @@ For Windows instructions [click here](#building-on-windows).

## Prerequisites

- Node.js `>= 10.11.0` **AND** `< 12.x`.
- Preferably, **use** version `10.15.3`, it has the [active LTS](https://github.com/nodejs/Release).
- Node.js `11.x` is untested.
- Node.js `12.x` is [unsupported](https://github.com/eclipse-theia/theia/issues/5117).
- Node.js `>= 12.14.1` **AND** `< 13`.
- Preferably, **use** version `12.18.3`, it has the [active LTS](https://nodejs.org/en/).
- [Yarn package manager](https://yarnpkg.com/en/docs/install) v1.7.0
- git (If you would like to use the Git-extension too, you will need to have git version 2.11.0 or higher.)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.0",
"engines": {
"yarn": "1.0.x || >=1.2.1",
"node": ">=10.11.0 <13"
"node": ">=12.14.1 <13"
},
"resolutions": {
"**/@types/node": "~10.3.6",
Expand Down

0 comments on commit e7fd33a

Please sign in to comment.