Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terminal] add padding to the left #1064

Closed
svenefftinge opened this issue Jan 16, 2018 · 2 comments
Closed

[terminal] add padding to the left #1064

svenefftinge opened this issue Jan 16, 2018 · 2 comments
Labels
terminal issues related to the terminal

Comments

@svenefftinge
Copy link
Contributor

svenefftinge commented Jan 16, 2018

The terminal should get some space on the left-hand side as soon as
xtermjs/xterm.js#1208 is merged and consumed by us.

@svenefftinge svenefftinge added the terminal issues related to the terminal label Jan 16, 2018
@svenefftinge
Copy link
Contributor Author

I see a comment in the code https://github.com/theia-ide/theia/blob/master/packages/terminal/src/browser/terminal.css#L21

But I don't really understand what the issue is. At least I could move the padding-leftup to the .terminal-container class it looks good.

@mofux
Copy link

mofux commented Jan 17, 2018

@svenefftinge I think you are right, adding a left padding to the parent container should work fine as of now. xtermjs/xterm.js#1208 is especially useful if you want to maintain a padding to the right, top or bottom edges while still having the scrollbar of the viewport filling the whole space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal
Projects
None yet
Development

No branches or pull requests

2 participants