Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor] [typescript] block comments not properly displayed for multiple lines #5229

Closed
vince-fugnitto opened this issue May 23, 2019 · 5 comments
Labels
editor issues related to the editor help wanted issues meant to be picked up, require help textmate issues related to the textmate grammars

Comments

@vince-fugnitto
Copy link
Member

Description

Currently, if block-comments have multiple lines, they are rendered in the following way:

/**

Get a user's name

*/
protected getName(): string {
    return this.name;
}

I'd expect block-comments to work the same way they do in monaco and vscode and add a * for each new line:

/**
*
* Get a user's name
*
*/
protected getName(): string {
    return this.name;
}
@vince-fugnitto vince-fugnitto added the editor issues related to the editor label May 23, 2019
@vince-fugnitto vince-fugnitto added the help wanted issues meant to be picked up, require help label Jul 3, 2019
@BroKun
Copy link
Member

BroKun commented Aug 7, 2019

The language configuration item onEnterRules will solve this problem.

@BroKun BroKun added the textmate issues related to the textmate grammars label Aug 7, 2019
@akosyakov
Copy link
Member

@BroKun Is it the same in VS Code? I thought our textmate grammar should be aligned with their? If it is the case maybe we should fix in the upstream first, otherwise then we can move to use VS Code completely this fix will be lost. If it is just outdated grammar then please make a PR to update it.

@BroKun
Copy link
Member

BroKun commented Aug 7, 2019

@akosyakov The basic part is the same as VS Code, but there are some extra features that are different from javascript/javascriptreact/typescript/typescriptreact and jsx-tag. We are missing this part.
Currently we have separate configurations for these languages, although some parts are the same.

@akosyakov
Copy link
Member

@BroKun do you have an idea how to bring missing parts? Could you have a look into it?

@BroKun
Copy link
Member

BroKun commented Aug 7, 2019

@BroKun do you have an idea how to bring missing parts? Could you have a look into it?

Completing the configuration item should be fine, I will test it and give a PR.

BroKun added a commit to BroKun/theia that referenced this issue Aug 18, 2019
BroKun added a commit to BroKun/theia that referenced this issue Aug 18, 2019
BroKun added a commit to BroKun/theia that referenced this issue Sep 16, 2019
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor issues related to the editor help wanted issues meant to be picked up, require help textmate issues related to the textmate grammars
Projects
None yet
Development

No branches or pull requests

3 participants