-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[editor] [typescript] block comments not properly displayed for multiple lines #5229
Comments
The language configuration item |
@BroKun Is it the same in VS Code? I thought our textmate grammar should be aligned with their? If it is the case maybe we should fix in the upstream first, otherwise then we can move to use VS Code completely this fix will be lost. If it is just outdated grammar then please make a PR to update it. |
@akosyakov The basic part is the same as VS Code, but there are some extra features that are different from javascript/javascriptreact/typescript/typescriptreact and jsx-tag. We are missing this part. |
@BroKun do you have an idea how to bring missing parts? Could you have a look into it? |
Completing the configuration item should be fine, I will test it and give a PR. |
Signed-off-by: Brokun <[email protected]>
…nd jsx Signed-off-by: Brokun <[email protected]>
…nd jsx Signed-off-by: Brokun <[email protected]>
…nd jsx Signed-off-by: Brokun <[email protected]>
Description
Currently, if
block-comments
have multiple lines, they are rendered in the following way:I'd expect
block-comments
to work the same way they do in monaco and vscode and add a*
for each new line:The text was updated successfully, but these errors were encountered: