Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monaco] missing "toggle minimap" command #5500

Closed
fangnx opened this issue Jun 17, 2019 · 1 comment
Closed

[monaco] missing "toggle minimap" command #5500

fangnx opened this issue Jun 17, 2019 · 1 comment
Assignees
@fangnx
Labels
enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco

Comments

@fangnx
Copy link

fangnx commented Jun 17, 2019

We should add the "Toggle Minimap" command to the top bar menu and the quick-open.
@akosyakov akosyakov changed the title [core] missing "toggle minimap" command [monaco] missing "toggle minimap" command Jun 17, 2019
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco labels Jun 17, 2019
@vince-fugnitto
Copy link
Member

The way it works in VSCode is to have a command which updates the editor.minimap.enabled preference value at the User level. This should be quite easy to do.

https://github.com/microsoft/vscode/blob/7bc29bf67c17608b11e23a8497c8f1de5a0922cf/src/vs/workbench/contrib/codeEditor/browser/toggleMinimap.ts#L26-L29

@fangnx fangnx self-assigned this Jun 28, 2019
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 3, 2019
@fangnx
Fixed eclipse-theia#5500: implemented "Toggle Minimap" command
7e246b7 
Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 3, 2019
@fangnx
Fixed eclipse-theia#5500: implemented "Toggle Minimap" command
091a871 
Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 3, 2019
@fangnx
Fixed eclipse-theia#5500: implemented "Toggle Minimap" command
fc96aaa 
- Implemented the "Toggle Minimap" command in the command pallete.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 3, 2019
@fangnx
Fixed eclipse-theia#5500: implemented "Toggle Minimap" command
c9899f3 
- Implemented the "Toggle Minimap" command in the command pallete.

Signed-off-by: fangnx <[email protected]>
fangnx pushed a commit to fangnx/theia that referenced this issue Jul 5, 2019
Fixed eclipse-theia#5500: implemented "Toggle Minimap" command
46ffb73 
- Implemented the "Toggle Minimap" command in the command pallete.

Signed-off-by: fangnx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fangnx fangnx

Labels
enhancement issues that are enhancements to current functionality - nice to haves monaco issues related to monaco
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @fangnx @vince-fugnitto