Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-ext] 'mini-browser' pulled implicitly #5790

Closed
vince-fugnitto opened this issue Jul 24, 2019 · 0 comments · Fixed by #5791
Closed

[plugin-ext] 'mini-browser' pulled implicitly #5790

vince-fugnitto opened this issue Jul 24, 2019 · 0 comments · Fixed by #5791
Assignees
Labels
plug-in system issues related to the plug-in system quality issues related to code and application quality

Comments

@vince-fugnitto
Copy link
Member

Description

The @theia/mini-browser is pulled implicitly by the @theia/plugin-ext (webviews) which can cause problems when attempting to build an application that uses either the @theia/plugin-ext or @theia/plugin-ext-vscode without @theia/mini-browser as a dependency.

Screen Shot 2019-07-24 at 12 18 17 PM

Motivation from theia-ide/theia-apps#207 (comment)

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality plug-in system issues related to the plug-in system labels Jul 24, 2019
@vince-fugnitto vince-fugnitto self-assigned this Jul 24, 2019
vince-fugnitto added a commit that referenced this issue Jul 24, 2019
…-ext`

Fixes #5790

- the @theia/mini-browser is pulled implicitly by the @theia/plugin-ext (webviews)
which can cause problems when attempting to build an application that uses either
the @theia/plugin-ext or @theia/plugin-ext-vscode without @theia/mini-browser as a dependency.
- fix the issue by explicitly declaring `@theia/mini-browser` as a dependency to `@theia/plugin-ext`

Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Jul 24, 2019
Fixes #5790

- fixed the `@theia/` `no-implicit-dependencies` warnings from extensions
which used dependencies directly without declaring them in their package.json
- fixed issue in `@theia/plugin-ext` regarding incorrect import paths

Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto added a commit that referenced this issue Jul 25, 2019
Fixes #5790

- fixed the `@theia/` `no-implicit-dependencies` warnings from extensions
which used dependencies directly without declaring them in their package.json
- fixed issue in `@theia/plugin-ext` regarding incorrect import paths

Signed-off-by: Vincent Fugnitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system quality issues related to code and application quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant