-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some plugins are not loaded in time #5861
Comments
Metadata should be loaded in advance, activation events only to run the extension code. Is it something what is contributed by code? |
There is though one activation event which is not covered yet: https://github.com/microsoft/vscode/blob/051b669b61cd175cb06c8f4500498dbeef79114c/extensions/npm/package.json#L32 We should study maybe it should be activated before running any task. |
@elaihau i will try to address it with a new activation event. |
Signed-off-by: Anton Kosyakov <[email protected]>
Signed-off-by: Anton Kosyakov <[email protected]>
Signed-off-by: Anton Kosyakov <[email protected]>
Description
Task providers are not registered on Theia startup. Take
npm
for example, the npm tasks are not loaded untilpackage.json
is opened.Reproduction Steps
See GIF
OS and Theia version:
Ubuntu 18.04. Chrome. Theia example-browser, master branch as of Aug 5 2019.
Diagnostics:
Looks like "loading some plugins" is now event-driven?
Talked with @vince-fugnitto. We think probably it is related to this commit 6021d79 @akosyakov
The text was updated successfully, but these errors were encountered: