Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some plugins are not loaded in time #5861

Closed
elaihau opened this issue Aug 5, 2019 · 3 comments · Fixed by #5869
Closed

some plugins are not loaded in time #5861

elaihau opened this issue Aug 5, 2019 · 3 comments · Fixed by #5869
Assignees
Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@elaihau
Copy link
Contributor

elaihau commented Aug 5, 2019

Description

Task providers are not registered on Theia startup. Take npm for example, the npm tasks are not loaded until package.json is opened.

Peek 2019-08-05 09-45

Reproduction Steps

See GIF

OS and Theia version:
Ubuntu 18.04. Chrome. Theia example-browser, master branch as of Aug 5 2019.

Diagnostics:
Looks like "loading some plugins" is now event-driven?
Talked with @vince-fugnitto. We think probably it is related to this commit 6021d79 @akosyakov

@elaihau elaihau added bug bugs found in the application plug-in system issues related to the plug-in system labels Aug 5, 2019
@akosyakov
Copy link
Member

Metadata should be loaded in advance, activation events only to run the extension code. Is it something what is contributed by code?

@akosyakov
Copy link
Member

There is though one activation event which is not covered yet: https://github.com/microsoft/vscode/blob/051b669b61cd175cb06c8f4500498dbeef79114c/extensions/npm/package.json#L32

We should study maybe it should be activated before running any task.

@akosyakov akosyakov self-assigned this Aug 6, 2019
@akosyakov
Copy link
Member

@elaihau i will try to address it with a new activation event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants