Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tasks] support modifying existing problem matchers #6427

Closed
vince-fugnitto opened this issue Oct 21, 2019 · 1 comment · Fixed by #7455
Closed

[tasks] support modifying existing problem matchers #6427

vince-fugnitto opened this issue Oct 21, 2019 · 1 comment · Fixed by #7455
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

Description

VS Code supports the possibility of modifying existing problem matchers.
For instance, a user can define a base problem matcher in which they can further customize:

{
  "type": "npm",
  "script": "watch",
  "problemMatcher": {
    "base": "$tsc-watch",
    "applyTo": "allDocuments"
  },
  "isBackground": true
}

Based on their documentation, further customization includes the following properties:

  • background
  • fileLocation
  • owner
  • pattern
  • severity
  • source

Additional Information

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system labels Oct 21, 2019
@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Oct 22, 2019
@elaihau elaihau self-assigned this Mar 22, 2020
@elaihau
Copy link
Contributor

elaihau commented Mar 22, 2020

As the example in vscode documentation shows, "applyTo" is also modifiable.

elaihau added a commit that referenced this issue Mar 23, 2020
- VS Code supports the possibility of modifying existing problem matchers. With this change, Theia users can define a base problem matcher in which they can further customize the properties `background`, `fileLocation`, `applyTo`, `owner`, `severity`, `pattern`, and `source`.
- resolves #6427

Signed-off-by: Liang Huang <[email protected]>
elaihau added a commit to elaihau/theia that referenced this issue Mar 26, 2020
- VS Code supports the possibility of modifying existing problem matchers. With this change, Theia users can define a base problem matcher in which they can further customize the properties `background`, `fileLocation`, `applyTo`, `owner`, `severity`, `pattern`, and `source`.

- resolves eclipse-theia#6427

Signed-off-by: Liang Huang <[email protected]>
elaihau added a commit that referenced this issue Mar 30, 2020
- VS Code supports the possibility of modifying existing problem matchers. With this change, Theia users can define a base problem matcher in which they can further customize the properties `background`, `fileLocation`, `applyTo`, `owner`, `severity`, `pattern`, and `source`.

- resolves #6427

Signed-off-by: Liang Huang <[email protected]>
elaihau added a commit that referenced this issue Apr 1, 2020
- VS Code supports the possibility of modifying existing problem matchers. With this change, Theia users can define a base problem matcher in which they can further customize the properties `background`, `fileLocation`, `applyTo`, `owner`, `severity`, `pattern`, and `source`.

- resolves #6427

Signed-off-by: Liang Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants