Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Possible Emitter memory leak detected #6659

Closed
danidoedel opened this issue Nov 29, 2019 · 3 comments · Fixed by #7508
Closed

Error: Possible Emitter memory leak detected #6659

danidoedel opened this issue Nov 29, 2019 · 3 comments · Fixed by #7508
Assignees
@akosyakov
Labels
plug-in system issues related to the plug-in system

Comments

@danidoedel
Copy link

Description

Not sure if that is the right place or too plugin specific, but I'll drop it here anyway.
Let me know if you need more information and I'll try to provide them.

OS and Theia version:
Chrome OS 79.0.3945.42
Che-Theia eclipse-che/che-theia@4769b1a using Theia 84d8678

Diagnostics:

Extension-Host:PLUGIN_HOST(3678) starting instance
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/init()
Extension-Host:PLUGIN_HOST(3678): initializing(@eclipse-che/[email protected] with /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
Extension-Host:PLUGIN_HOST(3678): initializing(@eclipse-che/[email protected] with /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
Extension-Host:PLUGIN_HOST(3678): initializing(@eclipse-che/[email protected] with /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
Extension-Host:PLUGIN_HOST(3678): initializing(@eclipse-che/[email protected] with /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
Extension-Host:PLUGIN_HOST(3678): initializing(@eclipse-che/[email protected] with /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
Extension-Host:PLUGIN_HOST(3678): initializing([email protected] with /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
Extension-Host:PLUGIN_HOST(3678): initializing(@theia/[email protected] with /home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
Extension-Host:PLUGIN_HOST(3678): initializing([email protected] with /home/theia/node_modules/@theia/plugin-ext-vscode/lib/node/plugin-vscode-init.js)
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/main)
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/theia_yeoman_plugin.theia/lib/theia-yeoman-plugin-backend-plugin.js)
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/task_plugin.theia/lib/task-plugin-backend.js)
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_welcome_plugin.theia/lib/welcome-plugin.js)
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_theia_ssh_plugin.theia/lib/ssh-plugin-backend.js)
Extension-Host:Error parsing configurations: error: 4, length:  0, offset:  0
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_theia_factory_plugin.theia/lib/factory-plugin.js)
Extension-Host:Error: Possible Emitter memory leak detected. 31 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:403:9)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 32 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at Object.onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at new AutoFetcher (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/autofetch.js:22:28)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:409:31)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 33 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new ProgressManager (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:310:9)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:422:33)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 34 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:403:9)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 35 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at Object.onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at new AutoFetcher (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/autofetch.js:22:28)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:409:31)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Error: Possible Emitter memory leak detected. 36 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new ProgressManager (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:310:9)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:422:33)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_theia_containers_plugin.theia/lib/containers-plugin.js)
Extension-Host:Error: Possible Emitter memory leak detected. 37 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:403:9)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 38 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at Object.onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at new AutoFetcher (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/autofetch.js:22:28)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:409:31)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 39 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new ProgressManager (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:310:9)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:422:33)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:PLUGIN_HOST(3678): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_ports_plugin.theia/lib/ports-plugin.js)
Extension-Host:Error: Possible Emitter memory leak detected. 40 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:403:9)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 41 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at Object.onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at new AutoFetcher (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/autofetch.js:22:28)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:409:31)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
Extension-Host:Error: Possible Emitter memory leak detected. 42 listeners added. Use event.maxListeners to increase the limit (30)
    at Emitter.checkMaxListeners (/home/theia/node_modules/@theia/core/lib/common/event.js:256:26)
    at PreferenceRegistryExtImpl._event.Object.assign.maxListeners [as onDidChangeConfiguration] (/home/theia/node_modules/@theia/core/lib/common/event.js:223:27)
    at onDidChangeConfiguration (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/plugin-context.js:381:46)
    at /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:37:56
    at new ProgressManager (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:310:9)
    at new Repository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:422:33)
    at Model.openRepository (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/model.js:184:32)
@akosyakov akosyakov added 🤔 needs more info issues that require more info from the author plug-in system issues related to the plug-in system labels Nov 29, 2019
@akosyakov
Copy link
Member

@danidoedel Can you reproduce it with the vanilla Theia?

@akosyakov akosyakov removed the 🤔 needs more info issues that require more info from the author label Mar 3, 2020
@akosyakov
Copy link
Member

akosyakov commented Mar 3, 2020 •
edited
Loading

Ok, so now I see it almost in any PR. The issue is reproducible when you have enough VS Code extensions installed. I think we should scale allowed amount of max listeners with amount of extensions. 30 listeners is not enough.

But first check whether leaks are real, if so we are better to open PRs for corresponding VS Code extensions as well. It seems for instance that vscode python extension does not clean up sometimes.

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Mar 3, 2020
@akosyakov

This comment has been minimized.

Sign in to view
@akosyakov akosyakov self-assigned this Apr 6, 2020
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Apr 6, 2020
akosyakov added a commit that referenced this issue Apr 6, 2020
@akosyakov
fix #6659: align max listeners check with VS Code extensions' expecta…
d10f6e0 
…tions

Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov mentioned this issue Apr 6, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Apr 6, 2020
@akosyakov
fix #6659: align max listeners check with VS Code extensions' expecta…
9635203 
…tions

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Apr 7, 2020
@akosyakov
fix #6659: align max listeners check with VS Code extensions' expecta…
710c17b 
…tions

Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Apr 8, 2020
@akosyakov
fix #6659: align max listeners check with VS Code extensions' expecta…
67ba90a 
…tions

Signed-off-by: Anton Kosyakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

align max listeners check with VS Code extensions' expectations eclipse-theia/theia
2 participants
@akosyakov @danidoedel