Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accessibility] TOGGLE_MAXIMIZED overrides monaco tab capture #6996

Closed
caseyflynn-google opened this issue Jan 29, 2020 · 1 comment
Closed

[accessibility] TOGGLE_MAXIMIZED overrides monaco tab capture #6996

caseyflynn-google opened this issue Jan 29, 2020 · 1 comment
Assignees
@caseyflynn-google
Labels
accessibility issues related to accessbilitiy keybindings issues related to keybindings question user / developer questions

Comments

@caseyflynn-google
Copy link
Contributor

Description

The TOGGLE_MAXIMIZE keybinding overrides Monaco's toggleTabFocusMode which is required for a11y. Would it be alright if we modify the keybinding for TOGGLE_MAXIMIZE (maybe ctrl+shift+m or alt+m)?

Reproduction Steps

  1. Open chrome developer tools.
  2. Load Theia

Observe warning in console:
root WARN Collided keybinding is ignored; {"command":"editor.action.toggleTabFocusMode","keybinding":"ctrl+m"} collided with {"command":"core.toggleMaximized","keybinding":"ctrl+m"}

OS and Theia version:

ChromeOs
Theia 0.14.0
@caseyflynn-google caseyflynn-google added question user / developer questions accessibility issues related to accessbilitiy labels Jan 29, 2020
@caseyflynn-google caseyflynn-google self-assigned this Jan 29, 2020
@akosyakov
Copy link
Member

akosyakov commented Jan 29, 2020 •
edited
Loading

yes, it should be fine. I wonder is it true for all operating systems, sometimes Monaco is using different shortcuts.

@akosyakov akosyakov added the keybindings issues related to keybindings label Jan 29, 2020
caseyflynn-google added a commit to caseyflynn-google/theia that referenced this issue Jan 29, 2020
@caseyflynn-google
fix eclipse-theia#6996 TOGGLE_MAXIMIZED overrides monaco tab capture
8b06ea0 
Change modifies the default TOGGLE_MAXIMIZED keybinding from ctrl+m to
alt+m to ensure it does not overwrite a11y feature of Monaco "toggle tab
key moves focus".

Signed-off-by: Casey Flynn <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@caseyflynn-google @akosyakov
fix eclipse-theia#6996 TOGGLE_MAXIMIZED overrides monaco tab capture
3f9307b 
Change modifies the default TOGGLE_MAXIMIZED keybinding from ctrl+m to
alt+m to ensure it does not overwrite a11y feature of Monaco "toggle tab
key moves focus".

Signed-off-by: Casey Flynn <[email protected]>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@caseyflynn-google
fix eclipse-theia#6996 TOGGLE_MAXIMIZED overrides monaco tab capture
3ee8e68 
Change modifies the default TOGGLE_MAXIMIZED keybinding from ctrl+m to
alt+m to ensure it does not overwrite a11y feature of Monaco "toggle tab
key moves focus".

Signed-off-by: Casey Flynn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caseyflynn-google caseyflynn-google

Labels
accessibility issues related to accessbilitiy keybindings issues related to keybindings question user / developer questions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @caseyflynn-google