Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate VSCode API FileSystemProvider in FileSystem #7269

Closed
tsmaeder opened this issue Mar 4, 2020 · 2 comments
Closed

Integrate VSCode API FileSystemProvider in FileSystem #7269

tsmaeder opened this issue Mar 4, 2020 · 2 comments
Assignees
@akosyakov
Labels
filesystem issues related to the filesystem vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 4, 2020

Currently, when we register a file system provider via the VS Code API, we only register a resource provider. This means that we cannot do many interesting things like listing directories or accessing raw byte content or deleting files for files provided by plugins.
I propose that we refactor file system support to be modeled on VS Code files system providers with the node file system just being the provider for the "file" scheme.
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Mar 4, 2020

Possible dupe: #7127 but I'm not sure what @akosyakov means there.

@vince-fugnitto vince-fugnitto added filesystem issues related to the filesystem vscode issues related to VSCode compatibility labels Mar 4, 2020
@akosyakov
Copy link
Member

@tsmaeder it is fine to close #7127.

Yes, we should do it. It has to be done diligently though, FileSystem is very commonly used API.

@akosyakov akosyakov self-assigned this Apr 7, 2020
@akosyakov akosyakov mentioned this issue Apr 20, 2020
Closed
@akosyakov akosyakov mentioned this issue May 15, 2020
Merged
1 task
akosyakov added a commit that referenced this issue May 15, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
14bf704 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 15, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
8e98967 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 18, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
193321a 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 18, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
cb8af91 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 27, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
6cf2678 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 27, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
b94033e 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 27, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
f9a5153 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
fac50f3 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
6c9058c 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
f207756 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
a39503f 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue May 29, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
60a27c7 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 2, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
7796e3d 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 2, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
17cea80 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 2, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
b234c78 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 3, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
bc945ab 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 3, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
fc13654 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 3, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
b80c7a9 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 5, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
86a9c92 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 16, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
26a9eb0 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 16, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
55644b7 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 17, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
cdd359d 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 17, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
a7ecad9 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
2f066ac 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
b4c4321 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 29, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
dd4dd18 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 29, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
b06e1dd 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 30, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
f307cc6 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 30, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
28c85e7 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jun 30, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
664fb88 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 1, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
3ca7336 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 1, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
17a5583 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 2, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
046e672 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 5, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
636d08f 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 7, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
446e385 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 9, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
aef2b6e 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
0c24987
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
11ac08c
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
f5e30cc
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
152d5b8
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
a52c6ac
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
2c3db48
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
1b2826b
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
c053459
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
186e784
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fixup! fix #7269: complete support vscode.workspace.fs API
5cf3072
akosyakov added a commit that referenced this issue Jul 27, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
f408df3 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
2698007 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Jul 28, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
87c7840 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit that referenced this issue Aug 3, 2020
@akosyakov
fix #7269: complete support vscode.workspace.fs API
a8d9c09 
Signed-off-by: Anton Kosyakov <[email protected]>
minyoungyang pushed a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
@akosyakov @minyoungyang
fix eclipse-theia#7269: complete support vscode.workspace.fs API
96849ee 
Signed-off-by: Anton Kosyakov <[email protected]>
@t1m0thyj t1m0thyj mentioned this issue Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
filesystem issues related to the filesystem vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akosyakov @tsmaeder @vince-fugnitto