Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select All in Problem view #7531

Open
lmcbout opened this issue Apr 8, 2020 · 3 comments
Open

Select All in Problem view #7531

lmcbout opened this issue Apr 8, 2020 · 3 comments
Labels
problems issues related to the problems widget

Comments

@lmcbout
Copy link
Contributor

lmcbout commented Apr 8, 2020

Description

The Problems view should have Select All command similar to the debug console.
Current side-effect, it highlight the line range of the open editor right now

Reproduction Steps

Open a workspace which has some problems reported in the "Problem" view
Open a file in the editor
Select the Problem view and "CTRL +a" to Select All
--> observe the line range in the editor, it is also selected

OS and Theia version:
Theia 1.0 latest
Ubuntu 18.04

Diagnostics:

SelectAll

@vince-fugnitto
Copy link
Member

@lmcbout I'm not sure we should open an issue for every view, but rather we do it generally as commented already:

@vince-fugnitto vince-fugnitto added the problems issues related to the problems widget label Apr 8, 2020
@vince-fugnitto
Copy link
Member

I think the 'select all' in the problems-view should be a noop like in VS Code.
We can individually copy messages, but not select the entire widget and copy.

@akosyakov
Copy link
Member

akosyakov commented Apr 8, 2020

I think the 'select all' in the problems-view should be a noop like in VS Code.

ok, then it can be resolved by #7525 (comment)

No, actually select all globally delegates to DOM in VS Code. If it should be no-op for the problems view then the handler should be installed in the problem view extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problems issues related to the problems widget
Projects
None yet
Development

No branches or pull requests

3 participants