GH-7521: Enabled Select All in the Output
#7523
Conversation
`dynamic` -> `dymanic` Signed-off-by: Akos Kitta <[email protected]>
|
I am going to drop 7d97ebe once the review is over. |
| if (this.outputChannelManager.selectedChannel) { | ||
| const element = document.getElementById(OutputWidget.IDs.CONTENTS); | ||
| if (element) { | ||
| const selectElementContent = (what: HTMLElement) => { |
There was a problem hiding this comment.
[minor] perhaps we can find a better name instead of what.
There was a problem hiding this comment.
What do you suggest?
There was a problem hiding this comment.
What do you suggest?
I'm not sure, either content or even htmlElement?
Closes #7521. Signed-off-by: Akos Kitta <[email protected]>
@lmcbout it is not a side-effect of this pull-request since the bug currently occurs on |
|
Thank you for the review, @vince-fugnitto, and @lmcbout 👍 |
@vince-fugnitto is there an issue where the "Select all" for the Problem" view is tracked |
No, but there is a conversation here: #7525 (comment) |
What it does
It enables the
Select Allfunctionality in theOutputwidget. Enabled only if theOutputwidget is the active widget in the shell. It should work with Ctrl/Cmd+A keybindings by default. Closes #7521.How to test
Outputwidget. You can use theAPI Sample: Log to Outputcommand.Outputwidget is visible but not activeSelect Allvia the keyboard whilst the editor is active,Select Allvia the keyboard whilst the SIW widget is active andinputhas the focus.Review checklist
Reminder for reviewers