Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vscode-ripgrep, to solve proxy issue #8171

Closed
Niklas-Dahlquist opened this issue Jul 14, 2020 · 1 comment · Fixed by #8280
Closed

Upgrade vscode-ripgrep, to solve proxy issue #8171

Niklas-Dahlquist opened this issue Jul 14, 2020 · 1 comment · Fixed by #8280
Labels
dependencies pull requests that update a dependency file help wanted issues meant to be picked up, require help

Comments

@Niklas-Dahlquist
Copy link
Contributor

Bug Description:

Current used version of vscode-ripgrep doesn't handle proxy settings correctly. This is fixed in version 1.8.0. Upgrade yarn.lock file to use this version

vscode-ripgrep@^1.2.4:
version "1.8.0"
resolved "https://registry.yarnpkg.com/vscode-ripgrep/-/vscode-ripgrep-1.8.0.tgz#dfe7c2ae2a2032df8a8108765c2feef73474888a"
integrity sha512-/Q5XtePkTLLi8yplr5ai24pVEymRF62xH9xXrtj35GTaDCJg3zq1s1/L1UqhVbfNDv4OcMBYjyIAt/quEi3d5w==
dependencies:
https-proxy-agent "^4.0.0"
proxy-from-env "^1.1.0"

Steps to Reproduce:

  1. do yarn behind a proxy
  2. without the upgraded vscode-ripgrep it will fail like error /home/theia/node_modules/vscode-ripgrep: Command failed. #7384
@vince-fugnitto
Copy link
Member

@Niklas-Dahlquist would you like to prepare a pull-request to resolve the issue?

@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Jul 14, 2020
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jul 15, 2020
marcdumais-work added a commit that referenced this issue Jul 31, 2020
Fixes #8171

This will benefit the developres that build our example application behind
a firewall, since now `ripgrep` respects environment proxy settings.

Extenders can upgrade their own application's `yarn.lock` since this change
will not affect them.

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue Jul 31, 2020
Fixes #8171

This will benefit the developres that build our example application behind
a firewall, since now `ripgrep` respects environment proxy settings.

Extenders can upgrade their own application's `yarn.lock` since this change
will not affect them.

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue Jul 31, 2020
Fixes #8171

This will benefit the developres that build our example application behind
a firewall, since now `ripgrep` respects environment proxy settings.

Extenders can upgrade their own application's `yarn.lock` since this change
will not affect them.

Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work added a commit that referenced this issue Aug 1, 2020
Fixes #8171

This will benefit the developres that build our example application behind
a firewall, since now `ripgrep` respects environment proxy settings.

Extenders can upgrade their own application's `yarn.lock` since this change
will not affect them.

Signed-off-by: Marc Dumais <[email protected]>
minyoungyang pushed a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
Fixes eclipse-theia#8171

This will benefit the developres that build our example application behind
a firewall, since now `ripgrep` respects environment proxy settings.

Extenders can upgrade their own application's `yarn.lock` since this change
will not affect them.

Signed-off-by: Marc Dumais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file help wanted issues meant to be picked up, require help
Projects
None yet
3 participants