Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explorer]: Badge count for dirty editors #8296

Closed
Anasshahidd21 opened this issue Aug 4, 2020 · 0 comments · Fixed by #8316
Closed

[explorer]: Badge count for dirty editors #8296

Anasshahidd21 opened this issue Aug 4, 2020 · 0 comments · Fixed by #8316
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help navigator issues related to the navigator/explorer

Comments

@Anasshahidd21
Copy link
Contributor

Feature Description:

We can have a badge count for dirty editors opened, just like vscode. Currently we don't show any badge count for dirty editors.
unsaved

How to Reproduce:

  1. Open a file in Theia
  2. Make changes(with autosave off) and without saving, switch to a new file.
  3. No count for dirty editors are present.
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 4, 2020
Dirty Editors
2cdcae7 
Fixes: eclipse-theia#8296

1. Fix disposable.
2. fix code.

Signed-off-by: Anas Shahid <[email protected]>
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help navigator issues related to the navigator/explorer labels Aug 4, 2020
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 4, 2020
Dirty Editors
fc1d495 
Fixes: eclipse-theia#8296

1. Fix disposable.
2. fix code.

Signed-off-by: Anas Shahid <[email protected]>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 5, 2020
[explorer]: Badge count for dirty editors
3f597b4 
Fixes: eclipse-theia#8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 5, 2020
[explorer]: Badge count for dirty editors
ecdda15 
Fixes: eclipse-theia#8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
@Anasshahidd21 Anasshahidd21 mentioned this issue Aug 5, 2020
Merged
1 task
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 5, 2020
[explorer]: Badge count for dirty editors
f23d916 
Fixes: eclipse-theia#8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 6, 2020
[explorer]: Badge count for dirty editors
43c0a5b 
Fixes: eclipse-theia#8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 7, 2020
[explorer]: Badge count for dirty editors
19b7f5a 
Fixes: eclipse-theia#8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 7, 2020
[explorer]: Badge count for dirty editors
f20602b 
Fixes: eclipse-theia#8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Aug 10, 2020
[explorer]: Badge count for dirty editors
35f25a9 
Fixes: eclipse-theia#8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
vince-fugnitto pushed a commit that referenced this issue Aug 10, 2020
@vince-fugnitto
[explorer]: Badge count for dirty editors
1f795e4 
Fixes: #8296

Adds a badge count for dirty editors on the explorer tab icon.

Signed-off-by: Anas Shahid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help navigator issues related to the navigator/explorer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[explorer]: Badge count for dirty editors Anasshahidd21/theia
2 participants
@akosyakov @Anasshahidd21