Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell] Error when toggling the bottom panel with Cltr/Cmd+j when there isn't any views in the bottom panel #8413

Closed
kittaakos opened this issue Aug 21, 2020 · 0 comments · Fixed by #8420
Closed

[shell] Error when toggling the bottom panel with Cltr/Cmd+j when there isn't any views in the bottom panel #8413

kittaakos opened this issue Aug 21, 2020 · 0 comments · Fixed by #8420
Labels
bug bugs found in the application shell issues related to the core shell

Comments

@kittaakos
Copy link
Contributor

Bug Description:

logger-protocol.ts:112 root ERROR Failed to execute command: Error: The command 'core.toggle.bottom.panel' cannot be executed. There are no active handlers available for the command. (args: [null])
    at CommandRegistry.<anonymous> (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:57675:45)
    at step (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:57444:23)
    at Object.next (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:57425:53)
    at file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:57419:71
    at new Promise (<anonymous>)
    at ./node_modules/@theia/core/lib/common/command.js.__awaiter (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:57415:12)
    at CommandRegistry../node_modules/@theia/core/lib/common/command.js.CommandRegistry.executeCommand (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:57657:16)
    at KeybindingRegistry../node_modules/@theia/core/lib/browser/keybinding.js.KeybindingRegistry.executeKeyBinding (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:35205:38)
    at KeybindingRegistry../node_modules/@theia/core/lib/browser/keybinding.js.KeybindingRegistry.run (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:35297:22)
    at HTMLDocument.<anonymous> (file:///Applications/Arduino%20Pro%20IDE.app/Contents/Resources/app/lib/bundle.js:33430:35)

Steps to Reproduce:

  1. Make sure you do not have anything in the bottom panel.
  2. Toggle it with the appropriate keybinding.

Additional Information

  • Operating System:
  • Theia Version:
@vince-fugnitto vince-fugnitto added bug bugs found in the application shell issues related to the core shell labels Aug 21, 2020
kittaakos pushed a commit that referenced this issue Aug 24, 2020
GH-8413: Execute the command if has active handler
6b5bcd8 
Before executing the command via a keybinding, we check if the command
has an active handler.

Closes #8413.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Aug 24, 2020
Merged
1 task
kittaakos pushed a commit that referenced this issue Aug 28, 2020
@kittaakos
GH-8413: Execute the command if has active handler
befac7f 
Before executing the command via a keybinding, we check if the command
has an active handler.

Closes #8413.

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application shell issues related to the core shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-8413: Execute the command if has active handler eclipse-theia/theia
2 participants
@kittaakos @vince-fugnitto