Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum DebugConsoleMode #10113

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Conversation

smart-bo
Copy link
Contributor

@smart-bo smart-bo commented Sep 15, 2021

What it does

Fixes: #10009

Add enum DebugConsoleMode to theia.d.ts

How to test

  • confirm that references to DebugConsoleMode now can correctly go to definition in theia.d.ts

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Sep 15, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

@vince-fugnitto
Copy link
Member

@smart-bo in case you were not aware, you can link issues with keywords so that they are automatically closed when the pull-request is merged. I've taken the liberty of updating the pull-request description to do so 👍

@vince-fugnitto vince-fugnitto merged commit de7b81b into eclipse-theia:master Sep 20, 2021
@vince-fugnitto vince-fugnitto added this to the 1.18.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DebugConsoleMode
3 participants