navigator-decorator: add symlink icon and tooltip to symlinked files in navigator

[Archie27376]

What it does

This commit adds a new decorator for the file navigator.
It displays a downward right curved arrow at the tail of a file node if that file contains a symbolic link.
A tooltip is also added displaying "Symbolic Link" when hovering over a symbolic linked file node's tail icon.
Hovering over the file itself will display the file path only.

How to test

• Have a symbolic linked file within a folder
• Open either the electron app or browser and select the folder with the symlinked file as a workspace
• Confirm symlinked file node contains icon on the tail
• Confirm tooltip displays "Symbolic Link" when hovering over the tail icon

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

I confirmed that the decorator correctly works for symlinks 👍

[msujew]

The feature looks good to me and most of the code as well. I have one suggestion to the code though, as we also had recent discussions on constructor vs. field injection during the dev-meetings.

[alvsan09]

I have tested it and compared with vscode as you can see in the '.gif'
Hovering over the symlink entry in theia. the tooltip does not show the suffix text " - Symbolic Link".

A second observation:
The decorator shows it fine for files, but it shows a different one for folders, is this intended ?

[vince-fugnitto]

@alvsan09

Hovering over the symlink entry in theia. the tooltip does not show the suffix text " - Symbolic Link".

I believe it is currently difficult to do in the framework, the same is true for badges such as scm, or debug:

• Update tooltip for tab-bar on badge decoration #8352

A second observation: The decorator shows it fine for files, but it shows a different one for folders, is this intended?

The issue is unrelated, due to #8352 we treat all folder nodes where decorations are present to display the generic dot decoration.

[alvsan09]

@Archie27376, as per the clarifications from Vince,
if you could please update the PR description, the test procedure and commit message so we don't expect the "Symbolic Link" suffix upon hovering.

[vince-fugnitto]

The changes look good to me 👍

• the symlink decoration is added to the navigator
• the decoration and tooltip work well

@kenneth-marut-work what would be needed in order to apply the same decoration from the navigator to the open-editors, I would assume they should share decoration contributions?

[kenneth-marut-work]

The changes look good to me 👍

• the symlink decoration is added to the navigator
• the decoration and tooltip work well

@kenneth-marut-work what would be needed in order to apply the same decoration from the navigator to the open-editors, I would assume they should share decoration contributions?

Should hopefully be as simple as adding bind(OpenEditorsTreeDecorator).toService(NavigatorSymlinkDecorator) in navigator-frontend-module. The ProblemDecorator and ScmNavigatorDecorator follow the same pattern.

Happy to give it a review once that's implemented

[kenneth-marut-work]

Looks like the decorators applied nicely to open editors. I didn't notice any issues with this PR when testing (including deleting symlinked files). Nice work

[alvsan09]

I have verified that the symlink decorators apply as expected in the explorer view as well as in open editors, the tooltip in the Explorer view clearly indicates it's a symbolic link 👍

The code looks good to me!!